-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix:Ensure security.txt file ends with a newline character #45508
fix:Ensure security.txt file ends with a newline character #45508
Conversation
hey @joshtrichards can u tell me what's wrong in my commit , i couldn't understand it.. |
Signed-off-by: Archisman Das <archisman.officials@gmail.com>
decd456
to
e1331d9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Cypress CI will not work on forked repositories, so this is expected to be red
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Summary
This commit addresses issue #42611 by ensuring that the generated
security.txt
file consistently ends with a newline character. This change aligns the file with the recommended best practices outlined in RFC 9116.Additionally, the commit updates the relevant unit test to verify that the newline character is correctly added.
TODO
before
after
Checklist