-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[stable27] fix(theming): stable 27 disable accessible color config switch #45422
Conversation
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
But that is expected, no? Black on black does not work for accessibility. |
yes, this is also what I am understanding but seems like the customer complains about exactly this, no? |
No the complaint is the before image which shows the folder color used for dark and light |
EDIT: @AndyScherzinger the colour shift is till being done, but the computation is different to be accessible. |
I see. 👍 |
@skjnldsv how would the light theme look like in 28 with that color? That is the main concern with the given color code |
|
Sweet, so v28 looks good to me 👍 |
Fix #39551
Only for 27! 28 and above have a different handling of themes and is fixed
Apply this fix
'27-disable-accessible-theming-color' => true,
to yourconfig.php
global
folder on yourdata/appdata_xxxx/theming
directory (no need to delete the theming folder)occ files:scan-app-data theming
How to reproduce the issue
#004352