Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable28] feat: Limit email input to 255 chars #45289

Merged
merged 2 commits into from
May 28, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented May 13, 2024

Backport of #44218

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Remove all the empty commits

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot backportbot bot requested review from Altahrim, susnux and Fenn-CS May 13, 2024 10:49
@backportbot backportbot bot added bug 3. to review Waiting for reviews labels May 13, 2024
@backportbot backportbot bot added this to the Nextcloud 28.0.6 milestone May 13, 2024
@Fenn-CS Fenn-CS marked this pull request as ready for review May 13, 2024 10:51
@Fenn-CS Fenn-CS requested review from artonge and Pytal May 13, 2024 10:53
return $this->createLoginFailedResponse(
$user,
$user,
$redirect_url,

Check notice

Code scanning / Psalm

PossiblyNullArgument Note

Argument 3 of OC\Core\Controller\LoginController::createLoginFailedResponse cannot be null, possibly null value provided
This was referenced May 15, 2024
@joshtrichards
Copy link
Member

/compile rebase-amend /

@joshtrichards joshtrichards added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels May 28, 2024
Fenn-CS and others added 2 commits May 28, 2024 21:29
Excessively long emails reported make server unresponsive.

We could at some point, consider adding a configuration for sysadmins to bypass this setting
on their instance if they want.

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@joshtrichards joshtrichards merged commit 36ba08e into stable28 May 28, 2024
54 checks passed
@joshtrichards joshtrichards deleted the backport/44218/stable28 branch May 28, 2024 22:21
@blizzz blizzz mentioned this pull request Jun 11, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants