Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add variable for inputs border width #45247

Merged
merged 1 commit into from
May 29, 2024
Merged

Add variable for inputs border width #45247

merged 1 commit into from
May 29, 2024

Conversation

marcoambrosini
Copy link
Member

@marcoambrosini marcoambrosini commented May 10, 2024 •
edited
Loading

Border width variable for input elements such as text fields and selects

@marcoambrosini marcoambrosini requested a review from a team May 10, 2024 07:42
@marcoambrosini marcoambrosini self-assigned this May 10, 2024
susnux
susnux reviewed May 10, 2024
View reviewed changes
core/css/variables.scss Outdated Show resolved Hide resolved
@marcoambrosini marcoambrosini requested a review from susnux May 10, 2024 13:58
@marcoambrosini marcoambrosini force-pushed the add-border-width branch 2 times, most recently from c1b402e to 1978048 Compare May 13, 2024 07:59
@marcoambrosini marcoambrosini requested a review from ShGKme May 13, 2024 08:00
come-nc
come-nc reviewed May 13, 2024
View reviewed changes
Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is it used?

@marcoambrosini
Copy link
Member Author

In the vue library, and potentially other places
nextcloud-libraries/nextcloud-vue#5563

@marcoambrosini
Copy link
Member Author

marcoambrosini commented May 14, 2024 •
edited
Loading

  • Add variable for focused input too

@susnux susnux force-pushed the add-border-width branch from f36d51a to 6b42c0b Compare May 16, 2024 21:19
@susnux susnux enabled auto-merge May 16, 2024 21:19
@joshtrichards joshtrichards added this to the Nextcloud 30 milestone May 28, 2024
@joshtrichards joshtrichards added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels May 28, 2024
@marcoambrosini @joshtrichards
feat(theming): Add variable for border width
9ebbd4b 
Signed-off-by: Marco Ambrosini <marcoambrosini@proton.me>
@susnux susnux merged commit e5d25dc into master May 29, 2024
156 checks passed
@susnux susnux deleted the add-border-width branch May 29, 2024 13:02
@blizzz blizzz mentioned this pull request Jul 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@come-nc come-nc come-nc left review comments

@szaimen szaimen szaimen approved these changes

@ShGKme ShGKme ShGKme approved these changes

@artonge artonge artonge approved these changes

@susnux susnux susnux approved these changes

@jancborchardt jancborchardt jancborchardt approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees

@marcoambrosini marcoambrosini

Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement
Projects
🖍 Design team
Archived in project
Milestone
Nextcloud 30
Development

Successfully merging this pull request may close these issues.
8 participants
@marcoambrosini @jancborchardt @susnux @artonge @ShGKme @szaimen @come-nc @joshtrichards