Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable28] fix(setupchecks): Fix opcache buffer check #45112

Merged
merged 1 commit into from
May 6, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Apr 30, 2024

Backport of #45106

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot backportbot bot added the 3. to review Waiting for reviews label Apr 30, 2024
@backportbot backportbot bot added this to the Nextcloud 28.0.6 milestone Apr 30, 2024
@come-nc come-nc force-pushed the backport/45106/stable28 branch from 6618d22 to 36ae1dc Compare April 30, 2024 12:06
@come-nc come-nc marked this pull request as ready for review April 30, 2024 12:06
@come-nc come-nc enabled auto-merge April 30, 2024 12:06
@come-nc come-nc changed the title [stable28] [stable29] fix(setupchecks): Fix opcache buffer check [stable28] fix(setupchecks): Fix opcache buffer check Apr 30, 2024
@come-nc come-nc force-pushed the backport/45106/stable28 branch from 36ae1dc to 105bcc2 Compare May 2, 2024 09:03
This was broken because of operator precedence.
Now using vars to make it readable and correct at the same time.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc come-nc force-pushed the backport/45106/stable28 branch from 105bcc2 to 2531676 Compare May 6, 2024 16:02
@come-nc come-nc merged commit b649ee9 into stable28 May 6, 2024
53 of 54 checks passed
@come-nc come-nc deleted the backport/45106/stable28 branch May 6, 2024 17:33
@skjnldsv skjnldsv mentioned this pull request May 15, 2024
28 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants