-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make trusted_domains
and overwrite.cli.url
sensitive config values
#45085
base: master
Are you sure you want to change the base?
Conversation
…values Signed-off-by: Jörg Mechnich <joerg.mechnich@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still against this. Especially if it will result in people asking for the uncensored report to find out about broken URLs.
The only way to convince me would be to add some sensitive check that shows whether the URLs are valid, overwrite.cli.url is within the array, contains the protocol and whether it contains a path
@nickvergessen |
I'll add it on my todo for the next hackweek |
Draft at #45382 |
Summary
Add
trusted_domains
andoverwrite.cli.url
to the list of sensitive configuration parameters.Checklist