Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix truncation on public page #44923

Merged
merged 2 commits into from
Apr 23, 2024
Merged

fix: Fix truncation on public page #44923

merged 2 commits into from
Apr 23, 2024

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Apr 18, 2024 •
edited
Loading

Summary

Before After
image image

Checklist

@Pytal Pytal added bug design Design, UI, UX, etc. 3. to review Waiting for reviews labels Apr 18, 2024
@Pytal Pytal added this to the Nextcloud 30 milestone Apr 18, 2024
@Pytal Pytal requested review from susnux, juliusknorr and artonge April 18, 2024 17:55
@Pytal Pytal self-assigned this Apr 18, 2024
jancborchardt
jancborchardt reviewed Apr 22, 2024
View reviewed changes
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should actually be a subline of the title on the left, instead of being pushed to the right. Must have regressed at some point?

@Pytal Pytal added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Apr 23, 2024
@Pytal Pytal marked this pull request as draft April 23, 2024 00:04
@Pytal Pytal force-pushed the fix/public-share-truncation branch from da3310f to d3ef076 Compare April 23, 2024 01:28
Pytal added 2 commits April 22, 2024 18:30
@Pytal
fix: Fix truncation on public shares
9546f4c 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
chore: compile assets
f01b80e 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal force-pushed the fix/public-share-truncation branch from d3ef076 to f01b80e Compare April 23, 2024 01:30
@Pytal Pytal marked this pull request as ready for review April 23, 2024 01:32
@Pytal Pytal added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Apr 23, 2024
@Pytal Pytal requested a review from jancborchardt April 23, 2024 01:32
jancborchardt
jancborchardt approved these changes Apr 23, 2024
View reviewed changes
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @Pytal! :)
Just to be sure – this will then also work on public pages of apps which don’t have a subline, right? (So that the main line is just vertically aligned correctly, and not up top.)

@Pytal
Copy link
Member Author

Pytal commented Apr 23, 2024

Looks great, thanks @Pytal! :) Just to be sure – this will then also work on public pages of apps which don’t have a subline, right? (So that the main line is just vertically aligned correctly, and not up top.)

Yes, without the subline the main line will still be vertically aligned :)

@Pytal Pytal merged commit 5b85562 into master Apr 23, 2024
160 of 161 checks passed
@Pytal Pytal deleted the fix/public-share-truncation branch April 23, 2024 17:17
@Pytal
Copy link
Member Author

Pytal commented Apr 23, 2024

/backport to stable29

@Pytal
Copy link
Member Author

Pytal commented Apr 23, 2024

/backport to stable28

@Pytal
Copy link
Member Author

Pytal commented Apr 23, 2024

/backport to stable27

@backportbot backportbot bot mentioned this pull request Apr 23, 2024
Merged
2 tasks
This was referenced Apr 23, 2024
Merged
Merged
@blizzz blizzz mentioned this pull request Jul 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artonge artonge artonge approved these changes

@susnux susnux susnux approved these changes

@jancborchardt jancborchardt jancborchardt approved these changes

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

Assignees

@Pytal Pytal

Labels
3. to review Waiting for reviews bug design Design, UI, UX, etc.
Projects
None yet
Milestone
Nextcloud 30
Development

Successfully merging this pull request may close these issues.

Title on public pages is truncated
4 participants
@Pytal @jancborchardt @susnux @artonge