-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sharingDetails): Show correct share target #44839
Conversation
/backport to stable29 |
/backport to stable28 |
/backport to stable27 |
Please use the right type for your commit message. Refactoring is changing code without changing behavior. |
bb08417
to
918d96b
Compare
918d96b
to
eb8be64
Compare
/compile |
The share details page should show the target email or user/server to which the user is creating the share. Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
2685d0a
to
8ec15c4
Compare
/compile |
/backport to stable29 |
/backport to stable28 |
/backport to stable27 |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you!
The backport to # Switch to the target branch and update it
git checkout stable27
git pull origin stable27
# Create the new backport branch
git checkout -b backport/44839/stable27
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 8ec15c44 3a5ff0f6
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/44839/stable27 Error: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
The backport to # Switch to the target branch and update it
git checkout stable28
git pull origin stable28
# Create the new backport branch
git checkout -b backport/44839/stable28
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 8ec15c44 3a5ff0f6
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/44839/stable28 Error: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
/backport to stable28 |
/backport to stable27 |
The backport to # Switch to the target branch and update it
git checkout stable28
git pull origin stable28
# Create the new backport branch
git checkout -b backport/44839/stable28
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 8ec15c44 3a5ff0f6
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/44839/stable28 Error: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
The backport to # Switch to the target branch and update it
git checkout stable27
git pull origin stable27
# Create the new backport branch
git checkout -b backport/44839/stable27
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 8ec15c44 3a5ff0f6
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/44839/stable27 Error: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! |
The share details page should show the target email or user/server to which
the user is creating the share.