-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tests): Fix tests when daytime saving time change happened recently #44612
Merged
come-nc
merged 1 commit into
master
from
fix/fix-share-manager-tests-near-daytime-change
Apr 2, 2024
Merged
fix(tests): Fix tests when daytime saving time change happened recently #44612
come-nc
merged 1 commit into
master
from
fix/fix-share-manager-tests-near-daytime-change
Apr 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Altahrim
approved these changes
Apr 2, 2024
come-nc
requested review from
a team,
ArtificialOwl,
icewind1991 and
sorbaugh
and removed request for
a team
April 2, 2024 09:31
/backport to stable29 |
/backport to stable28 |
/backport to stable27 |
nickvergessen
approved these changes
Apr 2, 2024
miaulalala
approved these changes
Apr 2, 2024
st3iny
approved these changes
Apr 2, 2024
This was referenced Apr 2, 2024
The backport to # Switch to the target branch and update it
git checkout stable29
git pull origin stable29
# Create the new backport branch
git checkout -b backport/44612/stable29
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick fda1c42a
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/44612/stable29 Error: Failed to push branch backport/44612/stable29: fatal: could not read Username for 'https://github.com': No such device or address Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
/backport to stable29 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix the quite corner case we are currently having in CI: recent daytime saving time change in Europe is making the share date expiration test fail.
Somehow the tests are also not correctly independent and having this one fail messed up 6 others, by leaving behind a hook expectation it seems.
The bug comes from the order of timezone change and day removal, if you change timezone first and remove 2 days after you do not get the same hours as if you do it the other way around.
Can be tested with this:
Current output (on 2024-04-02):
Checklist