Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle errors in encryption:migrate-key-storage-format #44555

Merged
merged 2 commits into from
Dec 4, 2024
Merged

Handle errors in encryption:migrate-key-storage-format #44555

merged 2 commits into from
Dec 4, 2024

Conversation

come-nc
Copy link
Contributor

@come-nc come-nc commented Mar 28, 2024 •
edited
Loading

Summary

If a path cannot be opened the error is now shown in the output and processing continues.

Checklist

@come-nc come-nc added this to the Nextcloud 30 milestone Mar 28, 2024
@come-nc come-nc self-assigned this Mar 28, 2024
@come-nc

This comment was marked as outdated.

Sign in to view
@backportbot backportbot bot mentioned this pull request Mar 28, 2024
Closed
2 tasks
@come-nc come-nc requested review from a team, ArtificialOwl, yemkareems and sorbaugh and removed request for a team April 22, 2024 14:34
@skjnldsv skjnldsv added 2. developing Work in progress stale Ticket or PR with no recent activity and removed 3. to review Waiting for reviews labels Jul 27, 2024
This was referenced Jul 30, 2024
Merged
Merged
@AndyScherzinger AndyScherzinger force-pushed the fix/handle-errors-in-migrate-key-format branch from 669775f to 5fe4ad8 Compare August 1, 2024 13:45
This was referenced Aug 5, 2024
Merged
Merged
@skjnldsv skjnldsv mentioned this pull request Aug 13, 2024
Merged
@skjnldsv skjnldsv modified the milestones: Nextcloud 30, Nextcloud 31 Aug 14, 2024
@skjnldsv skjnldsv marked this pull request as draft November 15, 2024 13:11
@come-nc
chore: Improve typing in core/Command/Encryption/MigrateKeyStorage.php
6dfa09f 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
fix: Show errors in encryption:migrate-key-storage-format and continu…
1d80351 
…e to other files

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc come-nc force-pushed the fix/handle-errors-in-migrate-key-format branch from 5fe4ad8 to 1d80351 Compare December 4, 2024 13:24
@come-nc come-nc marked this pull request as ready for review December 4, 2024 13:39
@come-nc come-nc removed the 2. developing Work in progress label Dec 4, 2024
@come-nc come-nc added 3. to review Waiting for reviews and removed stale Ticket or PR with no recent activity labels Dec 4, 2024
@Altahrim Altahrim merged commit 811f10e into master Dec 4, 2024
193 checks passed
@Altahrim Altahrim removed the 3. to review Waiting for reviews label Dec 4, 2024
@Altahrim Altahrim deleted the fix/handle-errors-in-migrate-key-format branch December 4, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@provokateurin provokateurin provokateurin approved these changes

@Altahrim Altahrim Altahrim approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl was automatically assigned from nextcloud/server-backend

@yemkareems yemkareems Awaiting requested review from yemkareems yemkareems was automatically assigned from nextcloud/server-backend

@sorbaugh sorbaugh Awaiting requested review from sorbaugh sorbaugh was automatically assigned from nextcloud/server-backend

@icewind1991 icewind1991 Awaiting requested review from icewind1991

@artonge artonge Awaiting requested review from artonge

Assignees

@come-nc come-nc

Labels
feature: encryption (server-side)
Projects
None yet
Milestone
Nextcloud 31
Development

Successfully merging this pull request may close these issues.
4 participants
@come-nc @Altahrim @provokateurin @skjnldsv