Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(files): breadcrumbs drag-and-drop & unifying methods #44409

Merged
merged 7 commits into from
Apr 4, 2024
Merged

fix(files): breadcrumbs drag-and-drop & unifying methods #44409

merged 7 commits into from
Apr 4, 2024

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Mar 22, 2024 •
edited
Loading

Needs nextcloud-libraries/nextcloud-upload#1123
Needs nextcloud-libraries/nextcloud-upload#1131

Fix #42869
Fix #43313
Fix #44278

Progress

  • Drag and Drop Area
  • Breadcrumbs
  • File entry
  • Unify drag and drop recursive methods between the three components above
  • Tests

@skjnldsv skjnldsv mentioned this pull request Mar 22, 2024
Merged
7 tasks
@skjnldsv skjnldsv force-pushed the fix/files-dnd-files branch 2 times, most recently from 5d6b689 to e0bbf07 Compare March 24, 2024 10:22
@skjnldsv skjnldsv mentioned this pull request Apr 2, 2024
Merged
@skjnldsv skjnldsv force-pushed the fix/files-dnd-files branch 2 times, most recently from d69b501 to d24b062 Compare April 2, 2024 15:25
@skjnldsv skjnldsv marked this pull request as ready for review April 2, 2024 15:31
@skjnldsv skjnldsv requested review from susnux, emoral435 and a team April 2, 2024 15:32
@skjnldsv skjnldsv self-assigned this Apr 2, 2024
@skjnldsv skjnldsv requested review from szaimen and removed request for a team April 2, 2024 15:32
@skjnldsv skjnldsv added this to the Nextcloud 30 milestone Apr 2, 2024
@skjnldsv skjnldsv changed the title fix(files): breadcrumbs dnd fix(files): breadcrumbs drag-and-drop & unifying methods Apr 2, 2024
@skjnldsv skjnldsv requested a review from Pytal April 2, 2024 15:33
@skjnldsv skjnldsv force-pushed the fix/files-dnd-files branch from d24b062 to 3e433d7 Compare April 3, 2024 08:45
@skjnldsv skjnldsv requested a review from artonge April 3, 2024 08:46
@skjnldsv skjnldsv force-pushed the fix/files-dnd-files branch 2 times, most recently from d75aa4a to 6ce30a8 Compare April 3, 2024 09:00
@skjnldsv
fix(files): breadcrumbs dnd
f28157e 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
@skjnldsv skjnldsv force-pushed the fix/files-dnd-files branch 3 times, most recently from 95c9a1d to 24ec358 Compare April 4, 2024 10:01
@skjnldsv
Copy link
Member Author

skjnldsv commented Apr 4, 2024

/backport to stable29

@skjnldsv
Copy link
Member Author

skjnldsv commented Apr 4, 2024

/backport to stable28

@skjnldsv skjnldsv force-pushed the fix/files-dnd-files branch from 24ec358 to e922f4c Compare April 4, 2024 10:22
susnux
susnux approved these changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

apps/files/src/components/BreadCrumbs.vue Show resolved Hide resolved
apps/files/src/components/BreadCrumbs.vue Show resolved Hide resolved
apps/files/src/components/DragAndDropNotice.vue Outdated Show resolved Hide resolved
apps/files/src/services/DropService.ts Show resolved Hide resolved
skjnldsv added 6 commits April 4, 2024 13:33
@skjnldsv
feat(files): unify drag and drop methods
15bf34d 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
@skjnldsv
chore: adjusting cypress drag and drop tests
aacc7ab 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
@skjnldsv
chore: add drag and drop recursion and FilesystemAPI testing
38c7ca0 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
@skjnldsv
fix(files): breadcrumbs native drop event
1a3ad80 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
@skjnldsv
chore: add cypress video recording
45316f0 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
@skjnldsv
chore: compile assets
aebebde 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
@skjnldsv skjnldsv force-pushed the fix/files-dnd-files branch from e922f4c to aebebde Compare April 4, 2024 11:35
@skjnldsv skjnldsv enabled auto-merge April 4, 2024 11:35
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Apr 4, 2024
@skjnldsv skjnldsv merged commit 32e8605 into master Apr 4, 2024
104 checks passed
@skjnldsv skjnldsv deleted the fix/files-dnd-files branch April 4, 2024 11:56
This was referenced Apr 4, 2024
Merged
Merged
@blizzz blizzz mentioned this pull request Jul 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

@artonge artonge artonge approved these changes

@emoral435 emoral435 Awaiting requested review from emoral435

@szaimen szaimen Awaiting requested review from szaimen szaimen was automatically assigned from nextcloud/server-frontend

@Pytal Pytal Awaiting requested review from Pytal

Assignees

@skjnldsv skjnldsv

Labels
4. to release Ready to be released and/or waiting for tests to finish feature: files regression technical debt
Projects
None yet
Milestone
Nextcloud 30
3 participants
@skjnldsv @susnux @artonge