Fix/caldav/eventcomparisionservice uses wrong array comparison #44017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcwschaller
requested review from
ChristophWurst,
miaulalala and
tcitworld
as code owners
ChristophWurst
added
bug
3. to review
|
Do you mind adding a test to |
Done. Not really sure if such a small change warrants the tests, but if it helps the collaboration, I am happy to provide it. |
tcitworld
approved these changes
Mar 18, 2024
miaulalala
approved these changes
Mar 19, 2024
|
Can you squash all your commits into one? Easiest is probably: |
rcwschaller
force-pushed
the
fix/caldav/eventcomparisionservice-uses-wrong-array-comparison
branch
2 times, most recently
from
8998801 to
ebc3925
Compare
|
@miaulalala should be clean now. |
Old comparison implementation compares each element of the array against each other with no respect for the associated array label, which leads to wrongful removals because one value is accidentally present in a completely different label. New comparison works 'by-label' individually. Partly fixes nextcloud#41084 because changes between 'SEQUENCE' not present, 'SEQUENCE:0' and 'SEQUENCE:1' were not detected in the old implementation and thus no email update sent. Co-authored-by: Christoph Wurst <ChristophWurst@users.noreply.github.com> Signed-off-by: Robert C. Schaller <gtbc_robert.schaller@rsxc.de>
miaulalala
force-pushed
the
fix/caldav/eventcomparisionservice-uses-wrong-array-comparison
branch
from
ebc3925 to
fa6e613
Compare
|
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
skjnldsv
added
4. to release
|
/backport to stable26 |
|
/backport to stable27 |
|
/backport to stable28 |
This was referenced Mar 26, 2024
8 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the comparison of two arrays that contain relevant differences between two events.
Old comparison implementation compares each element of the array against each other with no respect for the associated array label, which leads to wrongful removals because one value is accidentally present in a completely different label. New comparison works 'by-label' individually.
Refer to php manual https://www.php.net/manual/en/function.array-diff.php
Partly fixes #41084 because changes between 'SEQUENCE' not present, 'SEQUENCE:0' and 'SEQUENCE:1' were not detected in the old implementation and thus no email update sent.
@miaulalala please inspect. Small fix for your otherwise comprehensive contribution for nextcloud/calendar#3919
TODO
#41084 needs to remain open as there is a second issue, which prevents the SEQUENCE evaluation in certain cases.
/backport to stable28
/backport to stable27
/backport to stable26