Add status code 429 for too many requests on ocs API requests #43611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Akhil <akhil@e.email>
solracsf
requested review from
a team,
ArtificialOwl,
icewind1991,
blizzz and
nickvergessen
and removed request for
a team
|
On which endpoint do you receive a 500? |
| @@ -81,6 +81,9 @@ | |||
| OC_API::respond($ex->getResult(), OC_API::requestedFormat()); | |||
| } catch (\OC\User\LoginException $e) { | |||
| OC_API::respond(new \OC\OCS\Result(null, \OCP\AppFramework\OCSController::RESPOND_UNAUTHORISED, 'Unauthorised')); | |||
| } catch (\OCP\Security\Bruteforce\MaxDelayReached) { | |||
There was a problem hiding this comment.
Isn't already handled a few lines up (line 67 in this code block) due to recent #41937? Or do I need to finish drinking my morning coffee? :)
@akhil1508 Did you by chance see this in a slightly outdated environment in the wild (latest v26, v27, and v28 should all handle this already)?
There was a problem hiding this comment.
Did you by chance see this in a slightly outdated environment in the wild (latest v26, v27, and v28 should all handle this already)?
Ahhh yes, my bad. Apologies!
|
Closing as the check is already there |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist