Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(files_reminders): Add reminder status indicator #43589

Merged
merged 7 commits into from
Mar 9, 2024
Merged

feat(files_reminders): Add reminder status indicator #43589

merged 7 commits into from
Mar 9, 2024

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Feb 15, 2024 •
edited
Loading

Summary

  • Add reminder status indicator to files list
  • Allow clearing reminders if set in dialog
  • Register dav plugin directly
  • Close submenu action after click like top-level actions
  • Other minor fixes
Screenshot
image
Before After
image image

Checklist

@Pytal Pytal added this to the Nextcloud 29 milestone Feb 15, 2024
@Pytal Pytal requested review from susnux and artonge February 15, 2024 01:24
@Pytal Pytal self-assigned this Feb 15, 2024
@Pytal Pytal requested a review from skjnldsv as a code owner February 15, 2024 01:24
@Pytal Pytal enabled auto-merge February 15, 2024 02:04
@Pytal Pytal force-pushed the feat/reminder-status branch 5 times, most recently from f043326 to c7aac71 Compare February 16, 2024 03:53
Pytal added 7 commits March 8, 2024 03:46
@Pytal
fix(files): Close submenu actions after click like top-level actions
810bb64 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
chore(files_reminders): Register dav plugin directly
5ae3556 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
feat(files_reminders): Add reminder status indicator
c9139c6 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
fix(files_reminders): Add year to date string if not in the same year
8f7829e 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
chore(files_reminders): Drop moment in favour of native js Date API
e309802 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
fix(files_reminders): Fix translations
107805b 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
chore: compile assets
cb68d4b 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal force-pushed the feat/reminder-status branch from c7aac71 to cb68d4b Compare March 8, 2024 11:53
@Pytal Pytal requested review from artonge, skjnldsv and szaimen March 8, 2024 11:53
@Pytal Pytal merged commit 6cf51f9 into master Mar 9, 2024
161 checks passed
@Pytal Pytal deleted the feat/reminder-status branch March 9, 2024 08:21
lovelgeorge99 pushed a commit to lovelgeorge99/server that referenced this pull request Mar 9, 2024
@Pytal @lovelgeorge99
Merge pull request nextcloud#43589 from nextcloud/feat/reminder-status
c8ef15b 
feat(files_reminders): Add reminder status indicator

Signed-off-by: Lovel George <lovelgeorge22@gmail.com>
@Altahrim Altahrim mentioned this pull request Mar 12, 2024
Merged
@danxuliu
Copy link
Member

danxuliu commented Apr 1, 2024

At least the fix for translations should be backported to Nextcloud 28. I do not know about the other changes, though, so... @Pytal, could you do the backport? Thanks! :-)

@Pytal
Copy link
Member Author

Pytal commented Apr 1, 2024

/backport 107805b to stable28

@backportbot backportbot bot mentioned this pull request Apr 1, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@artonge artonge artonge approved these changes

@susnux susnux Awaiting requested review from susnux

@szaimen szaimen Awaiting requested review from szaimen

Assignees

@Pytal Pytal

Labels
3. to review Waiting for reviews bug enhancement feature: files
Projects
None yet
Milestone
Nextcloud 29
Development

Successfully merging this pull request may close these issues.

Show reminder status in file list
5 participants
@Pytal @danxuliu @artonge @skjnldsv @szaimen