Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: config param 'overwritecondaddr' not working #42930

Merged
merged 3 commits into from
Jan 29, 2024
Merged

Fix: config param 'overwritecondaddr' not working #42930

merged 3 commits into from
Jan 29, 2024

Conversation

blizzz
Copy link
Member

@blizzz blizzz commented Jan 18, 2024

new PR of #30654 (author was not responsive)
fixes #6914

@blizzz blizzz added bug 3. to review Waiting for reviews labels Jan 18, 2024
@blizzz blizzz added this to the Nextcloud 29 milestone Jan 18, 2024
@blizzz blizzz mentioned this pull request Jan 18, 2024
Closed
@blizzz blizzz changed the title Fix/6914/overwritecond Fix: config param 'overwritecondaddr' not working Jan 18, 2024
@blizzz blizzz requested review from skjnldsv, a team, ArtificialOwl, Fenn-CS, nickvergessen and ChristophWurst and removed request for a team January 18, 2024 11:18
@blizzz
Copy link
Member Author

blizzz commented Jan 18, 2024

/skjnldsv-backport to stable28

@blizzz
Copy link
Member Author

blizzz commented Jan 18, 2024

/skjnldsv-backport to stable27

@blizzz
Copy link
Member Author

blizzz commented Jan 18, 2024

/skjnldsv-backport to stable26

@susnux
Copy link
Contributor

susnux commented Jan 22, 2024

@blizzz drone failure seems related:

1) Test\AppFramework\Http\RequestTest::testGetRequestUriWithOverwrite with data set #1 ('/scriptname.php/some/PathInfo', '/owncloud/', '123')
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-'/scriptname.php/some/PathInfo'
+'/test.php/some/PathInfo'

/drone/src/tests/lib/AppFramework/Http/RequestTest.php:1861

@blizzz
Copy link
Member Author

blizzz commented Jan 23, 2024

Yes, I need to adjust the tests next time I can take time for it :)

@blizzz blizzz added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 26, 2024
pavelkryl and others added 3 commits January 27, 2024 15:11
@pavelkryl @blizzz
fixing bug #6914: Config Param 'overwritecondaddr' not working
446ecbc 
- just ignoring/removing extra parameter 'protocol' as suggested by
  blizzz

Signed-off-by: Pavel Kryl <pavel@kryl.eu>
@pavelkryl @blizzz
code style: ommited space, reverted [code review]
30ad530
@blizzz
test(unit): fix RequestTest
216b95f 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz blizzz merged commit 3749c2c into master Jan 29, 2024
135 checks passed
@blizzz blizzz deleted the fix/6914/overwritecond branch January 29, 2024 08:56
@blizzz
Copy link
Member Author

blizzz commented Jan 29, 2024

/backport to stable28

@blizzz
Copy link
Member Author

blizzz commented Jan 29, 2024

/backport to stable27

@blizzz
Copy link
Member Author

blizzz commented Jan 29, 2024

/backport to stable26

@backportbot backportbot bot mentioned this pull request Jan 29, 2024
Merged
This was referenced Jan 29, 2024
Merged
Closed
@blizzz blizzz mentioned this pull request Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl was automatically assigned from nextcloud/server-backend

@Fenn-CS Fenn-CS Awaiting requested review from Fenn-CS Fenn-CS was automatically assigned from nextcloud/server-backend

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish bug
Projects
None yet
Milestone
Nextcloud 29
Development

Successfully merging this pull request may close these issues.

Config Param 'overwritecondaddr' not working
5 participants
@blizzz @susnux @ChristophWurst @skjnldsv @pavelkryl