Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable27] fix(files): service worker #42608

Merged
merged 1 commit into from
Jan 9, 2024
Merged

[stable27] fix(files): service worker #42608

merged 1 commit into from
Jan 9, 2024

Conversation

solracsf
Copy link
Member

@solracsf solracsf commented Jan 6, 2024

This is a partial backport of 3344f0f

Summary

Backports a fix which allows the service worker of the files app to be reigstered

Refused to create a worker from 'https://nextcloud.mydomain.de/index.php/apps/files/preview-service-worker.js' because it violates the following Content Security Policy directive: "script-src 'nonce-aFNJRWFwcklWUlMvTVM5WDZxdnBtOEtyeWh4OVpzbHBGckh3NkpGeHk4OD06L0c1OEJOU0RiRk9IYVg1OGpzN2NycnZoa2xrZU51WWhmY216M3ZNMHVKaz0='". Note that 'worker-src' was not explicitly set, so 'script-src' is used as a fallback.

Checklist

@solracsf solracsf added the 2. developing Work in progress label Jan 6, 2024
@solracsf solracsf added this to the Nextcloud 27.1.6 milestone Jan 6, 2024
@solracsf
Fix preview service worker
2c11f23 
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

Update ViewControllerTest.php

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

Update ViewController.php

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
@solracsf solracsf mentioned this pull request Jan 6, 2024
Closed
5 tasks
@solracsf solracsf added bug 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jan 6, 2024
@susnux susnux merged commit ffe1941 into stable27 Jan 9, 2024
37 checks passed
@susnux susnux deleted the backport27-fixServiceWorker branch January 9, 2024 20:48
@blizzz blizzz mentioned this pull request Jan 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@Pytal Pytal Awaiting requested review from Pytal

@artonge artonge Awaiting requested review from artonge

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug
Projects
None yet
Milestone
Nextcloud 27.1.6
Development

Successfully merging this pull request may close these issues.
3 participants
@solracsf @susnux @skjnldsv