Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cron): Respect config_is_read_only config in in cron and console commands #42449

Closed
wants to merge 2 commits into from

Conversation

helmo
Copy link
Contributor

@helmo helmo commented Dec 22, 2023

Summary

I’d like to keep the config and application code read-only for the webserver as an extra security measure.
We have the config_is_read_only config boolean for that, but still occ and cron complain about not being the config file owner.

Even if they do have write access, which I think atleast cron should be able to do without.

Checklist

Signed-off-by: Herman van Rink <rink@initfour.nl>
@helmo helmo force-pushed the check-config_is_read_only branch from 15eab2f to f473089 Compare December 22, 2023 09:42
@helmo helmo changed the title Respect config_is_read_only config in in cron and console commands fix(cron): Respect config_is_read_only config in in cron and console commands Dec 26, 2023
@szaimen szaimen added this to the Nextcloud 29 milestone Jan 13, 2024
@szaimen szaimen added the 3. to review Waiting for reviews label Jan 13, 2024
@helmo
Copy link
Contributor Author

helmo commented Mar 8, 2024

This has a merge conflict since #27613 was merged ... and I think that solved the same issue.

One minor detail remains, I've posted the string change in #44094

@helmo helmo closed this Mar 8, 2024
@skjnldsv skjnldsv removed this from the Nextcloud 29 milestone Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews feature: occ
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants