use correct mode constant of files:scan's --path option #41973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icewind1991
requested review from
a team,
ArtificialOwl,
Fenn-CS and
sorbaugh
and removed request for
a team
skjnldsv
approved these changes
Feb 24, 2024
Signed-off-by: Robin Appelman <robin@icewind.nl>
skjnldsv
force-pushed
the
files-scan-path-option
branch
from
2d93447
to
572faa1
Compare
bigcat88
approved these changes
Mar 15, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
InputArgument::OPTIONALhappens to be the same value asInputOption::VALUE_REQUIREDby chance, so the previous code works as expected by accident. But it's confusing for people reading the code.