Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optionally hide hidden files if accessed via public share #41947

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

wronny
Copy link
Member

@wronny wronny commented Nov 30, 2023

  • Resolves: # n/a

Summary

optionally hide hidden files if accessed via public share
config.php setting: hide_hidden_files_via_public_share_access true|false (default = false)

Nextcloud users are able to show/hide hidden files (starting with dot "."). However if a folder containing hidden files is accessed via a public share hidden files are shown. As far as I can see there is currently no option available to hide hidden files for public share access.

I'm not sure if this is a valid or the best way to implement this. It's just a way I figured out to implement it. By default this change should not have any impact. Only if enabled via config.php setting 'hide_hidden_files_via_public_share_access' => true hidden files are excluded from file list if a folder is accessed via a public share link.

Before (example using a nextcloud maps share)
before

After and enabled via config.php
after_and_enabled

TODO

  • [ ]

Checklist

config.php setting: hide_hidden_files_via_public_share_access true|false
(default = false)

Signed-off-by: wronny <github@wron.de>
lib/private/Files/View.php Fixed Show fixed Hide fixed
@skjnldsv skjnldsv added the 2. developing Work in progress label Feb 21, 2024
@susnux susnux added this to the Nextcloud 30 milestone Apr 18, 2024
This was referenced Jul 30, 2024
This was referenced Aug 5, 2024
@skjnldsv skjnldsv mentioned this pull request Aug 13, 2024
@skjnldsv skjnldsv removed this from the Nextcloud 30 milestone Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants