Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(search): Seach for persons as event attendees and organizers #41374

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

ChristophWurst
Copy link
Member

Summary

Allows the event search to react to person searches. These try to match the common name of the attendee with the user's display name.
Deduplicates events matching summary (from the search term) and person filter.

How to test

curl against https://localhost/ocs/v2.php/search/providers/calendar/search?term=Meeting&person=nc-user_admin

Checklist

@ChristophWurst ChristophWurst added enhancement 3. to review Waiting for reviews feature: caldav Related to CalDAV internals labels Nov 10, 2023
@ChristophWurst ChristophWurst added this to the Nextcloud 28 milestone Nov 10, 2023
@ChristophWurst ChristophWurst self-assigned this Nov 10, 2023
@blizzz blizzz mentioned this pull request Nov 10, 2023
@blizzz blizzz mentioned this pull request Nov 10, 2023
public function getSupportedFilters(): array {
return [
'term',
'person',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also support them:

Suggested change
'person',
'person',
'since',
'until',

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst force-pushed the feat/search/search-event-attendees branch from 8d3c68a to 9b8cb5c Compare November 10, 2023 17:56
@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 10, 2023
@ChristophWurst ChristophWurst merged commit 7556021 into master Nov 10, 2023
47 of 50 checks passed
@ChristophWurst ChristophWurst deleted the feat/search/search-event-attendees branch November 10, 2023 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement feature: caldav Related to CalDAV internals
Projects
Development

Successfully merging this pull request may close these issues.

🔎 Allow event date and attendee search in advanced search
3 participants