Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable27] fix(files): prevent redirect on heading column sort #41356

Merged
merged 1 commit into from
Nov 15, 2023
Merged

[stable27] fix(files): prevent redirect on heading column sort #41356

merged 1 commit into from
Nov 15, 2023

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Nov 9, 2023

Fix #38884

Seems like the old inline onclick="event.preventDefault()" isn't working after all

@skjnldsv
fix(files): prevent redirect on heading column sort
89fb419 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added this to the Nextcloud 27.1.4 milestone Nov 9, 2023
@skjnldsv skjnldsv requested review from mahibi, ShGKme and a team November 9, 2023 10:26
@skjnldsv skjnldsv self-assigned this Nov 9, 2023
@skjnldsv skjnldsv requested review from Fenn-CS, sorbaugh and emoral435 and removed request for a team November 9, 2023 10:26
@skjnldsv
Copy link
Member Author

skjnldsv commented Nov 9, 2023

/backport to stable26

emoral435
emoral435 approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@emoral435 emoral435 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@blizzz blizzz mentioned this pull request Nov 13, 2023
Merged
@ShGKme
Copy link
Contributor

ShGKme commented Nov 14, 2023

Seems like the old inline onclick="event.preventDefault()" isn't working after all

It is blocked by CSP

@blizzz blizzz merged commit 20cf4fd into stable27 Nov 15, 2023
37 checks passed
@blizzz blizzz deleted the fix/stable27/header-sort-redirect branch November 15, 2023 21:48
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Nov 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShGKme ShGKme ShGKme approved these changes

@emoral435 emoral435 emoral435 approved these changes

@mahibi mahibi Awaiting requested review from mahibi

@Fenn-CS Fenn-CS Awaiting requested review from Fenn-CS Fenn-CS was automatically assigned from nextcloud/server-frontend

@sorbaugh sorbaugh Awaiting requested review from sorbaugh sorbaugh was automatically assigned from nextcloud/server-frontend

Assignees

@skjnldsv skjnldsv

Labels
3. to review Waiting for reviews bug feature: files
Projects
None yet
Milestone
Nextcloud 27.1.4
Development

Successfully merging this pull request may close these issues.
4 participants
@skjnldsv @ShGKme @emoral435 @blizzz