Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(files): make sure we focus the parent actions submenu entry #41338

Merged
merged 2 commits into from
Jan 31, 2024
Merged

fix(files): make sure we focus the parent actions submenu entry #41338

merged 2 commits into from
Jan 31, 2024

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Nov 8, 2023

@skjnldsv skjnldsv added this to the Nextcloud 28 milestone Nov 8, 2023
@skjnldsv skjnldsv requested review from susnux and a team November 8, 2023 10:08
@skjnldsv skjnldsv self-assigned this Nov 8, 2023
@skjnldsv skjnldsv requested review from Fenn-CS and emoral435 and removed request for a team November 8, 2023 10:08
@skjnldsv skjnldsv mentioned this pull request Nov 8, 2023
Merged
@susnux
Copy link
Contributor

susnux commented Nov 8, 2023

I like this solution :)

@blizzz blizzz mentioned this pull request Nov 9, 2023
Merged
emoral435
emoral435 approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@emoral435 emoral435 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@emoral435
Copy link
Contributor

/compile amend /

This was referenced Nov 10, 2023
Merged
Merged
@blizzz blizzz mentioned this pull request Nov 20, 2023
Merged
5 tasks
@blizzz blizzz modified the milestones: Nextcloud 28, Nextcloud 29 Nov 23, 2023
@skjnldsv skjnldsv force-pushed the fix/nested-actions-back-focus branch from 23c98e1 to 7d1b719 Compare January 31, 2024 12:20
@skjnldsv
Copy link
Member Author

/compile

skjnldsv and others added 2 commits January 31, 2024 17:07
@skjnldsv
fix(files): make sure we focus the parent actions submenu entry
23899de 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@nextcloud-command @skjnldsv
chore(assets): Recompile assets
8257cba 
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@skjnldsv skjnldsv force-pushed the fix/nested-actions-back-focus branch from cd90639 to 8257cba Compare January 31, 2024 16:08
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 31, 2024
@skjnldsv
Copy link
Member Author

/backport 23899de to sable28

@skjnldsv skjnldsv merged commit 02e9cd6 into master Jan 31, 2024
93 checks passed
@skjnldsv skjnldsv deleted the fix/nested-actions-back-focus branch January 31, 2024 17:06
@backportbot backportbot

This comment was marked as resolved.

Sign in to view
@skjnldsv
Copy link
Member Author

/backport 23899de to stable28

@backportbot backportbot bot mentioned this pull request Jan 31, 2024
Merged
1 task
@blizzz blizzz mentioned this pull request Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

@emoral435 emoral435 emoral435 approved these changes

@Fenn-CS Fenn-CS Awaiting requested review from Fenn-CS Fenn-CS was automatically assigned from nextcloud/server-frontend

Assignees

@skjnldsv skjnldsv

Labels
4. to release Ready to be released and/or waiting for tests to finish accessibility feature: files
Projects
Files to vue
Status: Done
Milestone
Nextcloud 29
Development

Successfully merging this pull request may close these issues.
5 participants
@skjnldsv @susnux @emoral435 @blizzz @nextcloud-command