Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add timezone getter to ITimeFactory #41300

Merged
merged 1 commit into from
Feb 13, 2024
Merged

Add timezone getter to ITimeFactory #41300

merged 1 commit into from
Feb 13, 2024

Conversation

miaulalala
Copy link
Contributor

@miaulalala miaulalala commented Nov 6, 2023 •
edited
Loading

Summary

Add factory method to generate a \DateTimeZone object

Better testability

TODO

  • ...

Checklist

@miaulalala miaulalala added enhancement 3. to review Waiting for reviews labels Nov 6, 2023
@miaulalala miaulalala requested review from nickvergessen and a team November 6, 2023 11:11
@miaulalala miaulalala self-assigned this Nov 6, 2023
@miaulalala miaulalala requested review from ArtificialOwl, icewind1991 and sorbaugh and removed request for a team November 6, 2023 11:11
@miaulalala miaulalala marked this pull request as draft November 6, 2023 11:36
@miaulalala
Copy link
Contributor Author

Got some additional ideas, adding a DateTimeImmutable factory method with params would be nice too.

@solracsf solracsf added this to the Nextcloud 28 milestone Nov 21, 2023
@blizzz blizzz mentioned this pull request Nov 22, 2023
Merged
5 tasks
@blizzz blizzz modified the milestones: Nextcloud 28, Nextcloud 29 Nov 23, 2023
@miaulalala miaulalala force-pushed the enh/add-timezone-generator branch 3 times, most recently from a349f5e to 1436487 Compare February 12, 2024 15:15
@miaulalala miaulalala marked this pull request as ready for review February 12, 2024 15:15
@ChristophWurst ChristophWurst added the pending documentation This pull request needs an associated documentation update label Feb 13, 2024
@ChristophWurst
Copy link
Member

needs dev docs

@miaulalala miaulalala mentioned this pull request Feb 13, 2024
Merged
@miaulalala miaulalala removed the pending documentation This pull request needs an associated documentation update label Feb 13, 2024
@miaulalala
Add timezone getter to ITimeFactory
6434ce9 
Signed-off-by: Anna Larch <anna@nextcloud.com>
@miaulalala miaulalala merged commit 8822b16 into master Feb 13, 2024
155 checks passed
@miaulalala miaulalala deleted the enh/add-timezone-generator branch February 13, 2024 15:17
@blizzz blizzz mentioned this pull request Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@come-nc come-nc come-nc approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl was automatically assigned from nextcloud/server-backend

@icewind1991 icewind1991 Awaiting requested review from icewind1991 icewind1991 was automatically assigned from nextcloud/server-backend

@sorbaugh sorbaugh Awaiting requested review from sorbaugh sorbaugh was automatically assigned from nextcloud/server-backend

Assignees

@miaulalala miaulalala

Labels
3. to review Waiting for reviews enhancement
Projects
None yet
Milestone
Nextcloud 29
Development

Successfully merging this pull request may close these issues.
7 participants
@miaulalala @ChristophWurst @nickvergessen @AndyScherzinger @come-nc @blizzz @solracsf