Use OCP\Util::getL10N instead of OC::$server->getL10N #40633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
come-nc
force-pushed
the
fix/cleanup-ocp-baseline
branch
from
f8e444d
to
04018e0
Compare
4 tasks
come-nc
force-pushed
the
fix/cleanup-ocp-baseline
branch
from
04018e0
to
b600c70
Compare
come-nc
added
3. to review
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -354,7 +354,7 @@ | |||
| return @$this->invokeLDAPMethod('exopPasswd', $userDN, '', $password) || | |||
| @$this->invokeLDAPMethod('modReplace', $userDN, $password); | |||
| } catch (ConstraintViolationException $e) { | |||
| throw new HintException('Password change rejected.', \OC::$server->getL10N('user_ldap')->t('Password change rejected. Hint: ') . $e->getMessage(), (int)$e->getCode()); | |||
| throw new HintException('Password change rejected.', \OCP\Util::getL10N('user_ldap')->t('Password change rejected. Hint: ') . $e->getMessage(), (int)$e->getCode()); | |||
Check notice
Code scanning / Psalm
RedundantCast Note
come-nc
requested review from
a team,
ArtificialOwl,
icewind1991 and
Altahrim
and removed request for
a team
nickvergessen
approved these changes
Feb 1, 2024
Altahrim
approved these changes
Feb 2, 2024
come-nc
force-pushed
the
fix/cleanup-ocp-baseline
branch
from
485f0f4
to
d5eef63
Compare
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
…ome apps Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com> Signed-off-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
come-nc
force-pushed
the
fix/cleanup-ocp-baseline
branch
from
d5eef63
to
d97567a
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
OCPshould not refer to privateOCnamespace, ever.$server->getL10Nis deprecated.As there already was a helper in
OCP\Util, I am using that instead of having to call tedious\OCP\Server::get(OCP\L10N\IFactory::class)->get('appname')each time.TODO
core/andlib/privateChecklist