Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dashboard widgets api #40511

Merged
merged 2 commits into from
Sep 20, 2023
Merged

Fix dashboard widgets api #40511

merged 2 commits into from
Sep 20, 2023

Conversation

provokateurin
Copy link
Member

Summary

The interface was wrong since the implementation always used an associative array with the app id:

$this->widgets[$widget->getId()] = $widget;

Checklist

@provokateurin
Copy link
Member Author

/backport 7c209dc to stable27

@provokateurin
Copy link
Member Author

/backport 7c209dc to stable26

@provokateurin
Copy link
Member Author

/backport 7c209dc to stable25

@provokateurin provokateurin changed the title Fix/dashboard widgets api Fix dashboard widgets api Sep 19, 2023
Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops

@ChristophWurst
Copy link
Member

/backport 7c209dc to stable26

@provokateurin
Copy link
Member Author

/backport 7c209dc to stable25

Signed-off-by: jld3103 <jld3103yt@gmail.com>
Signed-off-by: jld3103 <jld3103yt@gmail.com>
@provokateurin provokateurin merged commit 716c5e0 into master Sep 20, 2023
40 checks passed
@provokateurin provokateurin deleted the fix/dashboard-widgets-api branch September 20, 2023 19:22
@backportbot-nextcloud
Copy link

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27

# Create the new backport branch
git checkout -b fix/foo-stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@backportbot-nextcloud
Copy link

The backport to stable26 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable26
git pull origin stable26

# Create the new backport branch
git checkout -b fix/foo-stable26

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@backportbot-nextcloud
Copy link

The backport to stable25 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable25
git pull origin stable25

# Create the new backport branch
git checkout -b fix/foo-stable25

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable25

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@ChristophWurst
Copy link
Member

Bot probably failed because of the late rebase that caused commits to receive a new sha1

@provokateurin
Copy link
Member Author

/backport 80e3064 to stable27

@provokateurin
Copy link
Member Author

/backport 80e3064 to stable26

@provokateurin
Copy link
Member Author

/backport 80e3064 to stable25

@provokateurin
Copy link
Member Author

Is it broken or do I need to trigger it somehow?

@ChristophWurst
Copy link
Member

broken or slow

@backportbot-nextcloud
Copy link

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27

# Create the new backport branch
git checkout -b fix/foo-stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@backportbot-nextcloud
Copy link

The backport to stable25 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable25
git pull origin stable25

# Create the new backport branch
git checkout -b fix/foo-stable25

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable25

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@backportbot-nextcloud
Copy link

The backport to stable26 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable26
git pull origin stable26

# Create the new backport branch
git checkout -b fix/foo-stable26

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@provokateurin
Copy link
Member Author

Alright, I guess they really need to be done manually.

@provokateurin
Copy link
Member Author

Not sure why the backport bot failed, doing the manually cherry-pick worked perfectly on all stable25-27 branches 🤷‍♀️

@ChristophWurst
Copy link
Member

The bot probably needs a restart

reboot tut gut

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants