fix mimetype not being updated when changing file extention on objectstore #40394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icewind1991
requested review from
a team,
ArtificialOwl,
nfebe and
sorbaugh
and removed request for
a team
|
/backport to stable27 |
|
/backport to stable26 |
|
/backport to stable25 |
come-nc
reviewed
Sep 21, 2023
Merged
skjnldsv
added
2. developing
This was referenced Mar 12, 2024
Merged
Merged
Merged
Merged
icewind1991
force-pushed
the
updater-change-mimetype-objectstore
branch
from
4857c27 to
19105d1
Compare
…bject store Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
updater-change-mimetype-objectstore
branch
from
19105d1 to
3719977
Compare
icewind1991
force-pushed
the
updater-change-mimetype-objectstore
branch
from
3400329 to
3719977
Compare
come-nc
approved these changes
Dec 9, 2024
provokateurin
approved these changes
Dec 9, 2024
skjnldsv
added
4. to release
This was referenced Dec 11, 2024
|
This is being backported to old versions, shouldn't 28/29/30 be backported too? 🤔 |
|
True, the original PR was just quite old |
|
/backport to stable30 |
|
/backport to stable29 |
|
/backport to stable28 |
This was referenced Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With object store the source entry no longer exists once we hit the updater, so the old code path for changing the mimetype wasn't triggered.