Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Admin AI settings javascript error #40328

Merged
merged 2 commits into from
Sep 11, 2023
Merged

Fix Admin AI settings javascript error #40328

merged 2 commits into from
Sep 11, 2023

Conversation

marcelklehr
Copy link
Member

make sure all task types we want to display actually exist.

Summary

When disabling a TextProcessing provider app after configuring in admin settings, AI settings is blank due to a js null pointer error.

Checklist

@miaulalala miaulalala requested review from a team, Pytal, szaimen and sorbaugh and removed request for a team September 8, 2023 09:36
@blizzz blizzz added this to the Nextcloud 28 milestone Sep 8, 2023
@blizzz blizzz added 3. to review Waiting for reviews bug labels Sep 8, 2023
@blizzz
Copy link
Member

blizzz commented Sep 8, 2023

/backport to stable27

make sure all task types we want to display actually exist

Signed-off-by: Marcel Klehr <mklehr@gmx.net>
@Pytal
Copy link
Member

Pytal commented Sep 8, 2023

/compile /

Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@blizzz blizzz merged commit 8c38bef into master Sep 11, 2023
41 checks passed
@blizzz blizzz deleted the fix/admin-ai-settings branch September 11, 2023 10:26
@backportbot-nextcloud
Copy link

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27

# Create the new backport branch
git checkout -b fix/foo-stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@marcelklehr
Copy link
Member Author

/backport to stable27

1 similar comment
@marcelklehr
Copy link
Member Author

/backport to stable27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants