Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable27] fix(CardDAV): allow disabling of the system address book #40200

Merged
merged 1 commit into from
Sep 6, 2023
Merged

[stable27] fix(CardDAV): allow disabling of the system address book #40200

merged 1 commit into from
Sep 6, 2023

Conversation

backportbot-nextcloud[bot]
Copy link

Backport of #39925

@backportbot-nextcloud backportbot-nextcloud bot added 27-feedback bug feature: carddav Related to CardDAV internals labels Sep 1, 2023
@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 27.1.0 milestone Sep 1, 2023
@st3iny st3iny mentioned this pull request Sep 4, 2023
Merged
st3iny
st3iny approved these changes Sep 4, 2023
View reviewed changes
Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Block merges during freezes / Block merges during freezes (pull_request)

😢

@miaulalala
fix(CardDAV): allow disabling of the system address book via config o…
6354dce 
…ption

Signed-off-by: Anna Larch <anna@nextcloud.com>
@skjnldsv
Copy link
Member

skjnldsv commented Sep 5, 2023

@blizzz can we merge?

@AndyScherzinger
Copy link
Member

Since there are several positive testers' feedback in, see #39925 (comment) I would say, fine to merge even though post-RC1

@skjnldsv skjnldsv added the 4. to release Ready to be released and/or waiting for tests to finish label Sep 5, 2023
@miaulalala
Copy link
Contributor

PHPUnit fails with:

 [InvalidArgumentException]                                            
  Database <oci> is not supported. sqlite, mysql, pgsql are supported.

@blizzz blizzz mentioned this pull request Sep 5, 2023
Merged
6 tasks
@blizzz
Copy link
Member

blizzz commented Sep 6, 2023

PHPUnit fails with:

 [InvalidArgumentException]                                            
  Database <oci> is not supported. sqlite, mysql, pgsql are supported.

Was a hiccup only

@blizzz blizzz merged commit b956f0f into stable27 Sep 6, 2023
36 of 37 checks passed
@blizzz blizzz deleted the backport/39925/stable27 branch September 6, 2023 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@st3iny st3iny st3iny approved these changes

@miaulalala miaulalala Awaiting requested review from miaulalala miaulalala is a code owner

@tcitworld tcitworld Awaiting requested review from tcitworld tcitworld is a code owner

@andrey18106 andrey18106 Awaiting requested review from andrey18106

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish 27-feedback bug feature: carddav Related to CardDAV internals
Projects
None yet
Milestone
Nextcloud 27.1.0
Development

Successfully merging this pull request may close these issues.
6 participants
@skjnldsv @AndyScherzinger @miaulalala @blizzz @ChristophWurst @st3iny