Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enh(settings): Load from disabled users endpoint #40169

Merged
merged 3 commits into from
Dec 1, 2023
Merged

enh(settings): Load from disabled users endpoint #40169

merged 3 commits into from
Dec 1, 2023

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Aug 31, 2023 •
edited
Loading

Summary

  • Load users directly from disabled users endpoint

Checklist

@Pytal Pytal added the 2. developing Work in progress label Aug 31, 2023
@Pytal Pytal self-assigned this Aug 31, 2023
@Pytal Pytal force-pushed the enh/add-disabled-users-endpoint branch from 303c153 to 4d63760 Compare September 9, 2023 00:13
@Pytal Pytal force-pushed the enh/load-disabled-users-directly branch from f0adf49 to 12ce9da Compare September 9, 2023 00:38
@Pytal Pytal changed the title [WIP] enh(settings): Load from disabled users endpoint enh(settings): Load from disabled users endpoint Sep 9, 2023
@Pytal Pytal marked this pull request as ready for review September 9, 2023 00:39
@Pytal Pytal added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Sep 9, 2023
@Pytal Pytal added this to the Nextcloud 28 milestone Sep 9, 2023
come-nc

This comment was marked as resolved.

Sign in to view

@come-nc come-nc force-pushed the enh/add-disabled-users-endpoint branch from 4d63760 to bc0fcbe Compare September 12, 2023 07:08
@Pytal Pytal force-pushed the enh/load-disabled-users-directly branch from 12ce9da to d690221 Compare September 12, 2023 23:10
@come-nc come-nc force-pushed the enh/add-disabled-users-endpoint branch from bc0fcbe to 93722e7 Compare September 18, 2023 13:33
@Pytal Pytal force-pushed the enh/load-disabled-users-directly branch from d690221 to c8acf37 Compare September 29, 2023 18:52
@provokateurin provokateurin removed their request for review September 29, 2023 18:54
@Pytal Pytal requested a review from artonge October 5, 2023 16:20
@come-nc

This comment was marked as resolved.

Sign in to view
@come-nc come-nc force-pushed the enh/add-disabled-users-endpoint branch from 93722e7 to 61da2b9 Compare October 9, 2023 10:04
@come-nc come-nc mentioned this pull request Oct 9, 2023
Merged
5 tasks
Base automatically changed from enh/add-disabled-users-endpoint to master October 10, 2023 11:33
@Pytal Pytal force-pushed the enh/load-disabled-users-directly branch from c8acf37 to 716c8b2 Compare October 16, 2023 22:56
@come-nc

This comment was marked as resolved.

Sign in to view
@skjnldsv skjnldsv mentioned this pull request Nov 1, 2023
Merged
@blizzz blizzz mentioned this pull request Nov 6, 2023
Merged
@Pytal Pytal mentioned this pull request Nov 8, 2023
Closed
@Pytal Pytal linked an issue Nov 8, 2023 that may be closed by this pull request
Disabled users tab not working unless searching #41342
Closed
@blizzz blizzz mentioned this pull request Nov 10, 2023
Merged
This was referenced Nov 14, 2023
Merged
Merged
@blizzz blizzz modified the milestones: Nextcloud 28, Nextcloud 29 Nov 23, 2023
@Pytal Pytal force-pushed the enh/load-disabled-users-directly branch 2 times, most recently from c0a3f40 to 822ba99 Compare November 28, 2023 19:23
@Pytal Pytal force-pushed the enh/load-disabled-users-directly branch from 822ba99 to 85e7887 Compare December 1, 2023 00:02
@Pytal
Copy link
Member Author

Pytal commented Dec 1, 2023

/backport to stable28

@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish feature: users and groups bug and removed 3. to review Waiting for reviews labels Dec 1, 2023
@Pytal Pytal mentioned this pull request Dec 1, 2023
Merged
@Pytal Pytal enabled auto-merge December 1, 2023 00:40
@Pytal Pytal disabled auto-merge December 1, 2023 00:40
Pytal and others added 3 commits November 30, 2023 17:15
@Pytal
enh(settings): Load from disabled users endpoint
f9bd957 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
chore: compile assets
ceca099 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@come-nc @Pytal
Invert parameter order in getDisabledUserList to be consistent
adc43ea 
This matches what was done in the calls and so fixes getting disabled
 user list when there are several backends returning disabled users.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@Pytal Pytal force-pushed the enh/load-disabled-users-directly branch from 85e7887 to adc43ea Compare December 1, 2023 01:15
@Pytal Pytal merged commit 2943304 into master Dec 1, 2023
48 of 50 checks passed
@Pytal Pytal deleted the enh/load-disabled-users-directly branch December 1, 2023 16:42
@blizzz blizzz mentioned this pull request Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

@artonge artonge artonge approved these changes

@come-nc come-nc come-nc approved these changes

Assignees

@Pytal Pytal

Labels
4. to release Ready to be released and/or waiting for tests to finish backport-request bug feature: users and groups
Projects
None yet
Milestone
Nextcloud 29
Development

Successfully merging this pull request may close these issues.

Disabled users tab not working unless searching
5 participants
@Pytal @come-nc @susnux @artonge @blizzz