Refactor OC\Server::getSecureRandom
#40124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
summersab
force-pushed
the
refactor/OC-Server-getSecureRandom
branch
from
b59ae1c
to
33c2f90
Compare
Signed-off-by: Andrew Summers <18727110+summersab@users.noreply.github.com>
summersab
force-pushed
the
refactor/OC-Server-getSecureRandom
branch
from
33c2f90
to
1395a53
Compare
Merged
This was referenced Mar 12, 2024
Merged
Merged
Merged
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
skjnldsv
requested review from
a team,
ArtificialOwl,
icewind1991,
sorbaugh and
Altahrim
and removed request for
a team
skjnldsv
approved these changes
May 30, 2024
come-nc
reviewed
May 30, 2024
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com> Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
Altahrim
approved these changes
May 30, 2024
Altahrim
added
4. to release
skjnldsv
reviewed
May 30, 2024
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the deprecated method
OC\Server::getSecureRandomand replaces it withOC\Server::get(\OCP\Security\ISecureRandom::class)throughout the entire NC codebase (excluding./appsand./3rdparty).Additionally, where necessary, the
\OCP\Security\ISecureRandomclass is imported via theusedirective.