don't believe sftp when it tells us the mtime is less than we know it is #40105
+33
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -413,14 +427,13 @@ | |||
| return false; | |||
| } | |||
| if (!$this->file_exists($path)) { | |||
| $this->getConnection()->put($this->absPath($path), ''); | |||
| return $this->getConnection()->put($this->absPath($path), ''); | |||
Check notice
Code scanning / Psalm
InternalMethod Note
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
sftp-known-mtime
branch
from
81cc406
to
4d6d716
Compare
| use phpseclib\Net\SFTP\Stream; | ||
|
|
||
| /** | ||
| * Uses phpseclib's Net\SFTP class and the Net\SFTP\Stream stream wrapper to | ||
| * provide access to SFTP servers. | ||
| */ | ||
| class SFTP extends \OC\Files\Storage\Common { | ||
| class SFTP extends \OC\Files\Storage\Common { |
Check notice
Code scanning / Psalm
DeprecatedInterface Note
| if ($updated) { | ||
| $req = \OC::$server->get(IRequest::class); | ||
| if ($req->getHeader('x-debug-updated')) { | ||
| header("x-debug-updated: '$path' updated $storageTime > $time", false); |
Check failure
Code scanning / Psalm
TaintedHeader Error
| if ($updated) { | ||
| $req = \OC::$server->get(IRequest::class); | ||
| if ($req->getHeader('x-debug-updated')) { | ||
| header("x-debug-updated: '$path' updated $storageTime > $time", false); |
Check failure
Code scanning / Psalm
TaintedHeader Error
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
sftp-known-mtime
branch
from
4d6d716
to
847f6f5
Compare
This was referenced Mar 12, 2024
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.