Reducing queries in ScanFiles.php #40019
Open
+52
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szaimen
requested review from
icewind1991,
CarlSchwan,
a team,
ArtificialOwl and
nfebe
and removed request for
a team
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
|
|
||
| if ($lastUser === $user) { | ||
| $this->logger->warning("User $user still has unscanned files after running background scan, background scan might be stopped prematurely"); | ||
| if ($this->config->getSystemValue('loglevel') > ILogger::WARN) { |
Check notice
Code scanning / Psalm
DeprecatedClass
There was a problem hiding this comment.
Checking the code there are not good alternatives.
There is a Psr\Log\LogLevel but it is a string, not a int.
|
Do you think the Samba's failure is my fault? I think it just not sleeped enough or something like that. https://drone.nextcloud.com/nextcloud/server/39214/7/3 A question, I see it usually fails the "Cypress" test in every PR. I'm doing something wrong? |
Merged
Signed-off-by: FedericoHeichou <federicoheichou@gmail.com>
Signed-off-by: FedericoHeichou <federicoheichou@gmail.com>
AndyScherzinger
force-pushed
the
master
branch
from
ff1c7ae to
6740a19
Compare
This was referenced Mar 12, 2024
Merged
Merged
Merged
skjnldsv
added
2. developing
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
By changing the approach to the problem, it will guarantee that all users are scanned and it will only perform 2 (or 3) fast queries without performing joins.
TODO
Checklist