set Doctrine to use nest transactions with savepoints #39589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Since we are bumping the major mostlikely with 28 anyway, I'm fine with queuing it for that release. |
2 tasks
showtime? |
tcitworld
force-pushed
the
enh/set-nest-transactions-with-savepoints
branch
from
0f43b5c to
72e1eec
Compare
Merged
tcitworld
added
3. to review
tcitworld
force-pushed
the
enh/set-nest-transactions-with-savepoints
branch
from
72e1eec to
73b4bd1
Compare
|
Rebased |
Using nested transactions without savepoints is actually deprecated by Doctrine: https://www.doctrine-project.org/projects/doctrine-dbal/en/current/reference/transactions.html#transaction-nesting Without savepoints, a nested transaction can be rollbacked but not handled properly in the "real" transaction, leading to the following error: Transaction commit failed because the transaction has been marked for rollback only. Ref #36528 (comment) (and possibly) #38902 (comment) Signed-off-by: Thomas Citharel <tcit@tcit.fr>
AndyScherzinger
force-pushed
the
enh/set-nest-transactions-with-savepoints
branch
from
73b4bd1 to
2a08154
Compare
This was referenced Mar 12, 2024
Merged
Merged
Merged
Altahrim
approved these changes
May 22, 2024
miaulalala
approved these changes
May 27, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using nested transactions without savepoints is actually deprecated by Doctrine: https://www.doctrine-project.org/projects/doctrine-dbal/en/current/reference/transactions.html#transaction-nesting
Without savepoints, a nested transaction can be rollbacked but not handled properly in the "real" transaction, leading to the following error:
Transaction commit failed because the transaction has been marked for rollback only.
Ref
#36528 (comment) (and possibly) #38902 (comment)
TODO
Checklist