-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make .devcontainer independent of processor architecture #39464
Closed
tsdicloud
wants to merge
7
commits into
nextcloud:master
from
nextmcloud:nmc/issues/39461-devcontainer-arm
Closed
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
2923f85
Replace hardcoded arm64 by auto detected architecture
tsdicloud 013c825
Clean network compose and NMC specific setup
tsdicloud 7d1c3e5
Avoid corrupted config, prohibit overwrite of config on NC stop
tsdicloud aefda25
Check db health to avoid start witout db ready
tsdicloud 7a6f7f1
addressing node and npm version compatibility issues
rhtot c983f5f
Revert "addressing node and npm version compatibility issues"
rhtot cd583c1
Merge branch 'master' into nmc/issues/39461-devcontainer-arm
memurats File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
<?php | ||
$CONFIG = array ( | ||
'apps_paths' => array ( | ||
0 => array ( | ||
'path' => OC::$SERVERROOT.'/customapps', | ||
'url' => '/customapps', | ||
'writable' => true, | ||
), | ||
1 => array ( | ||
'path' => OC::$SERVERROOT.'/apps', | ||
'url' => '/apps', | ||
'writable' => true, | ||
), | ||
), | ||
); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
<?php | ||
$CONFIG = array ( | ||
'config_is_read_only' => true, | ||
); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
<?php | ||
$CONFIG = array ( | ||
'htaccess.RewriteBase' => '/', | ||
'default_language' => 'de_DE', | ||
'integrity.check.disabled' => true, // not recommended for prod, but for customisation | ||
'auth.authtoken.v1.disabled' => true, | ||
'sharing.force_share_accept' => true, | ||
'status-email-message-provider' => '\\OCA\\EmailTemplateExample\\MessageProvider', | ||
'mail_template_class' => 'OCA\\EmailTemplateExample\\EMailTemplate', | ||
// "logfile_office_report" => "/var/log/nextcloud/office.log", | ||
); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
#!/bin/bash | ||
DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )/../" >/dev/null 2>&1 && pwd )" | ||
|
||
cd $DIR/ | ||
|
||
# after installation, do some MagentaCLOUD specific setups to start closer to production | ||
|
||
# customapps directory split | ||
cp .devcontainer/apps.config.php config/apps.config.php | ||
cp .devcontainer/nmc.config.php config/nmc.config.php | ||
|
||
# disable user themeing | ||
sudo -u ${APACHE_RUN_USER} php occ theming:config disable-user-theming yes | ||
|
||
# fixed themeing for MagentaCLOUD | ||
cp .devcontainer/theme.config.php config/theme.config.php | ||
|
||
# refresh .htaccess for short URL notation | ||
sudo -u ${APACHE_RUN_USER} php occ maintenance:update:htaccess | ||
|
||
# "Organisational" setting | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These look perhaps to be personal settings that I don't think belong in the PR |
||
sudo -u ${APACHE_RUN_USER} php occ theming:config color "#e20074" # don't use uppercase letters! | ||
sudo -u ${APACHE_RUN_USER} php occ theming:config name MagentaCLOUD | ||
sudo -u ${APACHE_RUN_USER} php occ theming:config slogan "Alle Dateien sicher an einem Ort" | ||
sudo -u ${APACHE_RUN_USER} php occ theming:config imprintUrl "http://www.telekom.de/impressum" | ||
sudo -u ${APACHE_RUN_USER} php occ theming:config privacyUrl "https://static.magentacloud.de/Datenschutz" | ||
|
||
# app settings | ||
sudo -u ${APACHE_RUN_USER} php occ config:app:set theming AndroidClientUrl --value \ | ||
"https://play.google.com/store/apps/details?=com.t_systems.android.webdav" | ||
sudo -u ${APACHE_RUN_USER} php occ config:app:set theming iTunesAppId --value "312838242" | ||
sudo -u ${APACHE_RUN_USER} php occ config:app:set theming iOSClientUrl --value \ | ||
"https://apps.apple.com/us/app/magentacloud-cloud-speicher/id312838242" | ||
|
||
# enable/disable apps | ||
sudo -u ${APACHE_RUN_USER} php occ app:enable nmctheme | ||
sudo -u ${APACHE_RUN_USER} php occ app:disable dashboard # may remove as soon as dashboard CR is implemented | ||
|
||
# there are side effects when using devcontainer and | ||
# doing the main settings via webapp. For the moment, the best | ||
# workaround is to lock config and avoid overwrite by nextcloud | ||
# esp. on container rebuild | ||
cp .devcontainer/lock.config.php config/lock.config.php |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
<?php | ||
$CONFIG = array ( | ||
'enforce_theme' => 'default', // or any other theme contained in the app | ||
'theme' => '', // disable old themeing | ||
); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR appears to include a bunch of unrelated changes. Was that intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd say keep them as an example for custom setup, like separated here, which can be adapted by others
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tsdicloud feel free to remove the nmc specific files of course, since I would expect you wouldn't want them in the Nextcloud repo instead of just the nmc one