Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable27] fix(files): fix legacy router query change #39301

Merged
merged 1 commit into from
Jul 11, 2023
Merged

[stable27] fix(files): fix legacy router query change #39301

merged 1 commit into from
Jul 11, 2023

Conversation

skjnldsv
Copy link
Member

Fix #38503

@skjnldsv skjnldsv added this to the Nextcloud 27.0.1 milestone Jul 11, 2023
@skjnldsv skjnldsv requested a review from a team July 11, 2023 07:48
@skjnldsv skjnldsv self-assigned this Jul 11, 2023
@skjnldsv skjnldsv requested review from susnux, Pytal and szaimen and removed request for a team July 11, 2023 07:48
szaimen
szaimen approved these changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and seems to fix the problem. Thanks for fixing this @skjnldsv ! :)

@skjnldsv
Copy link
Member Author

/compile amend /

@skjnldsv @nextcloud-command
fix(files): fix legacy router query change
af144f7 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@nextcloud-command nextcloud-command force-pushed the fix/legacy-navigate-param branch from d2d82e3 to af144f7 Compare July 11, 2023 12:01
@skjnldsv skjnldsv enabled auto-merge July 11, 2023 12:39
@skjnldsv skjnldsv requested a review from artonge July 11, 2023 15:33
@blizzz blizzz mentioned this pull request Jul 11, 2023
Merged
artonge
artonge approved these changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those? conditional? operators? are? really? useful !

@skjnldsv skjnldsv merged commit bb66a5e into stable27 Jul 11, 2023
@skjnldsv skjnldsv deleted the fix/legacy-navigate-param branch July 11, 2023 16:25
@szaimen szaimen mentioned this pull request Jul 14, 2023
Closed
9 tasks
@Mer0me Mer0me mentioned this pull request Jul 31, 2023
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szaimen szaimen szaimen approved these changes

@artonge artonge artonge approved these changes

@susnux susnux Awaiting requested review from susnux susnux was automatically assigned from nextcloud/server-frontend

@Pytal Pytal Awaiting requested review from Pytal Pytal was automatically assigned from nextcloud/server-frontend

Assignees

@skjnldsv skjnldsv

Labels
3. to review Waiting for reviews bug regression
Projects
Files to vue
Status: Done
Milestone
Nextcloud 27.0.1
Development

Successfully merging this pull request may close these issues.
3 participants
@skjnldsv @artonge @szaimen