full uppercase const #39276
Merged
full uppercase const #39276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -141,6 +140,6 @@ | |||
| } | |||
|
|
|||
| protected function isApplicable(StorageConfig $config) { | |||
| return ($config->getApplicableUsers() === [$this->getUser()->getUID()]) && $config->getType() === StorageConfig::MOUNT_TYPE_PERSONAl; | |||
| return ($config->getApplicableUsers() === [$this->getUser()->getUID()]) && $config->getType() === StorageConfig::MOUNT_TYPE_PERSONAL; | |||
Check notice
Code scanning / Psalm
PossiblyNullReference Note
nickvergessen
approved these changes
Jul 10, 2023
icewind1991
reviewed
Jul 10, 2023
| @@ -37,7 +37,7 @@ | |||
| */ | |||
| class DBConfigService { | |||
| public const MOUNT_TYPE_ADMIN = 1; | |||
| public const MOUNT_TYPE_PERSONAl = 2; | |||
There was a problem hiding this comment.
@icewind1991 should we merge or we keep both (DBConfigService and StorageConfig) definition ?
icewind1991
approved these changes
Jul 12, 2023
joshtrichards
approved these changes
Sep 5, 2023
Merged
skjnldsv
force-pushed
the
fix/noid/full-upper-const
branch
from
f264c4f
to
9a7286c
Compare
skjnldsv
added
4. to release
This comment was marked as resolved.
This comment was marked as resolved.
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
skjnldsv
force-pushed
the
fix/noid/full-upper-const
branch
from
9a7286c
to
2f41b9c
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix last character of
StorageConfig::MOUNT_TYPE_PERSONAl