Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor admin_audit app #39234

Merged
merged 2 commits into from
Feb 23, 2024
Merged

Conversation

shdehnavi
Copy link
Contributor

Summary

The required adjustments have been made to the admin_audit app.

The improvements:

  • Replacing qualifiers with imports
  • Adding return types
  • Adding types to properties
  • Updating doc blocks

Checklist

@shdehnavi shdehnavi requested a review from MorrisJobke July 8, 2023 20:47
@solracsf solracsf added this to the Nextcloud 28 milestone Jul 9, 2023
@solracsf solracsf added 3. to review Waiting for reviews technical debt labels Jul 9, 2023
@MorrisJobke MorrisJobke enabled auto-merge July 12, 2023 12:01
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 13, 2023
@skjnldsv skjnldsv force-pushed the refactor_admin_audit_app branch from f1f87f6 to 05fbfe9 Compare July 13, 2023 09:19
@skjnldsv skjnldsv mentioned this pull request Nov 1, 2023
This was referenced Nov 6, 2023
This was referenced Nov 14, 2023
@blizzz blizzz modified the milestones: Nextcloud 28, Nextcloud 29 Nov 23, 2023
shdehnavi and others added 2 commits February 23, 2024 16:17
Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>
Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>
Co-authored-by: John Molakvoæ <skjnldsv@protonmail.com>
Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>
@skjnldsv skjnldsv force-pushed the refactor_admin_audit_app branch from 05fbfe9 to 6e53cf2 Compare February 23, 2024 15:17
@provokateurin provokateurin removed their request for review February 23, 2024 15:19
@skjnldsv skjnldsv disabled auto-merge February 23, 2024 20:30
@skjnldsv skjnldsv merged commit 2e7e63d into nextcloud:master Feb 23, 2024
151 of 158 checks passed
@shdehnavi shdehnavi deleted the refactor_admin_audit_app branch February 26, 2024 10:50
@blizzz blizzz mentioned this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants