Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix event names of 2FA related typed events #39089

Merged
merged 1 commit into from
Jul 3, 2023
Merged

Fix event names of 2FA related typed events #39089

merged 1 commit into from
Jul 3, 2023

Conversation

nickvergessen
Copy link
Member

Checklist

@nickvergessen nickvergessen added this to the Nextcloud 28 milestone Jun 30, 2023
@nickvergessen nickvergessen self-assigned this Jun 30, 2023
@nickvergessen nickvergessen added the pending documentation This pull request needs an associated documentation update label Jun 30, 2023
@nickvergessen nickvergessen mentioned this pull request Jun 30, 2023
Merged
5 tasks
@nickvergessen nickvergessen force-pushed the bugfix/39087/fix-2fa-event-names branch from cfca6a8 to 6de0ae2 Compare June 30, 2023 12:33
@nickvergessen nickvergessen force-pushed the bugfix/39087/fix-2fa-event-names branch from 6de0ae2 to c544469 Compare July 3, 2023 09:24
@nickvergessen
Copy link
Member Author

Come and Christoph approved the commit in #39086 already, so setting to merge

@nickvergessen nickvergessen force-pushed the bugfix/39087/fix-2fa-event-names branch from c544469 to a87040e Compare July 3, 2023 09:36
@nickvergessen
Copy link
Member Author

Forgot the since on the public function __construct() methods

@nickvergessen
Fix event names of 2FA related typed events
05aa39d 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the bugfix/39087/fix-2fa-event-names branch from a87040e to 05aa39d Compare July 3, 2023 12:25
@nickvergessen nickvergessen merged commit 75d5fa4 into master Jul 3, 2023
40 of 46 checks passed
@nickvergessen nickvergessen deleted the bugfix/39087/fix-2fa-event-names branch July 3, 2023 13:38
@nickvergessen nickvergessen removed the pending documentation This pull request needs an associated documentation update label Jul 28, 2023
@nickvergessen
Copy link
Member Author

Docs in nextcloud/documentation#10858

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcelklehr marcelklehr marcelklehr approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@come-nc come-nc come-nc approved these changes

@rullzer rullzer Awaiting requested review from rullzer

@miaulalala miaulalala Awaiting requested review from miaulalala miaulalala is a code owner

Assignees

@nickvergessen nickvergessen

Labels
3. to review Waiting for reviews bug feature: authentication
Projects
None yet
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.

Events of TwoFactor provider and manager names are very confusing (at best)
4 participants
@nickvergessen @marcelklehr @ChristophWurst @come-nc