Make no-user entry with avatar when there is no others with access

[JeaNugroho]

• Resolves: Emptycontent view for "Others with access" section #18875

Summary

Make an empty entry with predefined info for when there's no others with access. This can be seen in the share tab inside the files view by clicking on any file/folder share button.

Before

Link to conversation

After (with avatar - first commit)

After (without avatar - second commit)

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[jancborchardt]

I'd say without avatar looks better, but the indent is good. (So the emptycontent text is indented as if there is an avatar, do you know what I mean? :)

[artonge]

Nice idea, few comments though :)

[JeaNugroho]

@jancborchardt

I'd say without avatar looks better, but the indent is good. (So the emptycontent text is indented as if there is an avatar, do you know what I mean? :)

This is what it looks like since the 3rd commit:

I hope this is what we wanted to achieve 😁

[artonge]

Nice, feels much cleaner :)

[nimishavijay]

Looks great with the fix! 🚀

[JeaNugroho]

Looks great with the fix! 🚀

@nimishavijay

Thanks, appreciate it! Do you mind reviewing another PR that I made? It's solving a simpler issue, and you can find it here.

On another note, I'm looking to work on some backend issues, and I would appreciate it if I can reach out to someone who I can ask about backend or any other questions to. And I might as well ask where would be a good place to chat with the person (if it's through help.cloud.com, I'd like to know which channel. Thanks in advance!

[JeaNugroho]

How can I merge these changes? @artonge @nimishavijay @jancborchardt
It says "Required statuses must pass before merging", but I'm not exactly sure on how to fix them or if there's any directions to do it. I hope someone can guide me on how to deliver these changes so it can be merged

[nimishavijay]

@JeaNugroho I am not too sure about the failing checks, maybe @szaimen or @artonge can help out here?
help.nextcloud.com is a great place to start asking about development questions! We also have a community Talk chat where there are a lot of active contributors who will also be able to help you out :)

[susnux]

It says "Required statuses must pass before merging", but I'm not exactly sure on how to fix them or if there's any directions to do it.

You need to fix the issues detected by the CI:

1. The Node CI fails because you need to build the JS assets and commit them (npm run build)
2. The Lint CI fails because you have some code style issues (they are also reported here on the changed files section), most of the time you can solve it by run npm run lint:fix.

[susnux]

LGTM, just see the comment about resolving the CI issues :)

[artonge]

Hey @JeaNugroho can you rebase and commit the compiled files again?
Any conflict under /dist can be ignored.

[JeaNugroho]

Hey @JeaNugroho can you rebase and commit the compiled files again?
Any conflict under /dist can be ignored.

@artonge Working on it! Is that why Node CI failed even after I tried to fix it? 😅

[JeaNugroho]

Have just rebased! I assume I'll have to wait for all checks to complete and continue fixing more issues in case some required CI checks fail. I hope someone can offer help with that failed required CI checks 😊
It was good help offered by @susnux , but had to start rebasing first after I attempted to do npm run build

@nimishavijay @artonge @jancborchardt

[artonge]

Can you run npm run lint:fix, and then rebase, compile, commit again?

Something like:

git fetch
git rebase origin/master
# Complete the rebase

npm run lint:fix
npm run build
git commit -am '...' --signoff
git push

[JeaNugroho]

Can you run npm run lint:fix, and then rebase, compile, commit again?

Something like:

git fetch
git rebase origin/master
# Complete the rebase

npm run lint:fix
npm run build
git commit -am '...' --signoff
git push

@artonge Yes I can! Though I'm not sure why the Node CI still fails even after I tried to sort it out. By the way, your terminal snippet shows that we rebase first and then fix the lint issues, which is not in the same order as what you mentioned in your question. I did the following comment using your snippet sequence fyi

[JeaNugroho]

@artonge So based on your last two comments, what should I do and what commands should I run? I only ran the commands discussed in this PR so far. I can close this PR and restart through a new PR if it's easier for everyone 😁

[artonge]

This page https://github.com/nextcloud/server/pull/39022/files need to display your changes only and the result of npm run build.

The rebase might have gone wrong.
If creating another PR is easier for you, then do that. But it should be possible to revert the state of this PR to contain your change only.

[skjnldsv]

Lots of conflicts and unrelated changes