Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

file scanner performance improvements #38858

Merged
merged 1 commit into from
Jun 26, 2023
Merged

Conversation

icewind1991
Copy link
Member

@icewind1991 icewind1991 commented Jun 16, 2023

  • Fixes some invalid logic around re-using known folder ids that was causing an extra select for every folder scanned
  • Properly forward known folder sizes during recursive scan, saving a select and an update for every folder scanned
  • Make scanChildren parameters non-option to simplify reasoning

Comparison scanning 23239 files over 466 folders

@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Jun 16, 2023
@icewind1991 icewind1991 added this to the Nextcloud 28 milestone Jun 16, 2023
@icewind1991 icewind1991 requested review from a team, ArtificialOwl, nfebe and come-nc and removed request for a team June 16, 2023 14:12
@icewind1991 icewind1991 force-pushed the scanner-performance3 branch 3 times, most recently from e054578 to a535fc6 Compare June 16, 2023 14:30
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 icewind1991 force-pushed the scanner-performance3 branch from a535fc6 to 561536f Compare June 16, 2023 14:31
@icewind1991 icewind1991 marked this pull request as ready for review June 16, 2023 15:57
@icewind1991 icewind1991 requested a review from artonge June 21, 2023 15:22
@icewind1991 icewind1991 merged commit 39a0554 into master Jun 26, 2023
@icewind1991 icewind1991 deleted the scanner-performance3 branch June 26, 2023 15:01
@icewind1991
Copy link
Member Author

/backport to stable27

@icewind1991
Copy link
Member Author

/backport to stable26

@backportbot-nextcloud
Copy link

The backport to stable26 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable26
git pull origin stable26

# Create the new backport branch
git checkout -b fix/foo-stable26

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants