Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

27.0.0 RC4 #38693

Merged
merged 1 commit into from
Jun 9, 2023
Merged

27.0.0 RC4 #38693

merged 1 commit into from
Jun 9, 2023

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Jun 8, 2023

Pending PRs:

@come-nc
Copy link
Contributor

come-nc commented Jun 8, 2023

From 32bit CI:

There were 2 errors:

1) OCA\Files_Trashbin\Tests\StorageTest::testCrossStorageDeleteFolder
rename(): The first argument to copy() function cannot be a directory

/__w/server/server/lib/private/Files/Storage/Local.php:378
/__w/server/server/lib/private/Files/Storage/Local.php:610
/__w/server/server/lib/private/Files/Storage/Wrapper/Quota.php:239
/__w/server/server/lib/private/Files/Storage/Wrapper/Wrapper.php:592
/__w/server/server/apps/files_trashbin/lib/Storage.php:239
/__w/server/server/apps/files_trashbin/lib/Trashbin.php:323
/__w/server/server/apps/files_trashbin/lib/Trash/LegacyTrashBackend.php:108
/__w/server/server/apps/files_trashbin/lib/Trash/TrashManager.php:102
/__w/server/server/apps/files_trashbin/lib/Storage.php:202
/__w/server/server/apps/files_trashbin/lib/Storage.php:125
/__w/server/server/lib/private/Files/View.php:1143
/__w/server/server/lib/private/Files/View.php:321
/__w/server/server/apps/files_trashbin/tests/StorageTest.php:252

2) OCA\Files_Trashbin\Tests\StorageTest::testKeepFileAndVersionsWhenMovingFolderBetweenStorages
rename(): The first argument to copy() function cannot be a directory

/__w/server/server/lib/private/Files/Storage/Local.php:378
/__w/server/server/lib/private/Files/Storage/Local.php:610
/__w/server/server/lib/private/Files/Storage/Wrapper/Wrapper.php:592
/__w/server/server/apps/files_trashbin/lib/Storage.php:239
/__w/server/server/lib/private/Files/View.php:796
/__w/server/server/apps/files_trashbin/tests/StorageTest.php:504
There were 6 failures:

1) TrashbinTest::testExpireOldFilesShared
Failed asserting that 0 is identical to 2.

/__w/server/server/apps/files_trashbin/tests/TrashbinTest.php:303
/__w/server/server/apps/files_trashbin/tests/TrashbinTest.php:286

2) OCA\Files_Trashbin\Tests\StorageTest::testDeleteVersionsOfFile
Failed asserting that 0 matches expected 1.

/__w/server/server/apps/files_trashbin/tests/StorageTest.php:288

3) OCA\Files_Trashbin\Tests\StorageTest::testDeleteVersionsOfFolder
Failed asserting that 0 matches expected 1.

/__w/server/server/apps/files_trashbin/tests/StorageTest.php:315

4) OCA\Files_Trashbin\Tests\StorageTest::testDeleteVersionsOfFileAsRecipient
Versions in owner's trashbin
Failed asserting that 0 matches expected 1.

/__w/server/server/apps/files_trashbin/tests/StorageTest.php:367

5) OCA\Files_Trashbin\Tests\StorageTest::testDeleteVersionsOfFolderAsRecipient
Failed asserting that 0 matches expected 1.

/__w/server/server/apps/files_trashbin/tests/StorageTest.php:419

6) OCA\Files_Trashbin\Tests\StorageTest::testTrashbinCollision
Failed asserting that false is true.

/__w/server/server/apps/files_trashbin/tests/StorageTest.php:681

I failed to reproduce or understand so far, but 32bit CI has been failing consistently for a week: https://github.com/nextcloud/server/actions/workflows/phpunit-32bits.yml
It passed on RC3.

I tried to bisect with nektos/act and got non-possible results (faulty commit was always something not touching PHP files)
Which seems to indicate that this failure is not consistent always.

@come-nc
Copy link
Contributor

come-nc commented Jun 8, 2023

I confirmed that the failures is also happening with RC3 on my setup (only 1 failure though, others are false positive I think).
Should be fixed by: #38703

@skjnldsv
Copy link
Member Author

skjnldsv commented Jun 9, 2023

#38717

@skjnldsv skjnldsv added the 3. to review Waiting for reviews label Jun 9, 2023
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added high 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jun 9, 2023
@skjnldsv skjnldsv merged commit c19eb78 into stable27 Jun 9, 2023
@skjnldsv skjnldsv deleted the release/27.0.0_rc4 branch June 9, 2023 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish high
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants