-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved display of app links #38520
Improved display of app links #38520
Conversation
Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>
Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>
May it be added to Nextcloud 27 Milestone ? |
you can summon the backport for this |
Hmmm, I've never done that before ; can you tell me the method ? @szaimen |
|
No, the milestone should stay Nextcloud 28. But you can summon the backport bot by so: |
/backport to stable27 |
@Jerome-Herbinet |
/backport to stable27 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
screenshots?
Thanks :-) |
Thanks @Jerome-Herbinet just to add that, when you are adding a screen add the before and after. Also you can add it as part of the original PR description (or first comment). Thanks for the work! |
Yep you are right, I did all that in a bit of a rush, sorry. |
@fenn-cs I updated the top first comment with the "before" and "after" screenshot. |
CI failure unrelated afaics |
The backport to stable27 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable27
git pull origin/stable27
# Create the new backport branch
git checkout -b fix/foo-stable27
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27 More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
/backport to stable27 |
The backport to stable27 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable27
git pull origin/stable27
# Create the new backport branch
git checkout -b fix/foo-stable27
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27 More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
/backport e25fb29 to stable27 |
Respawn of #37823
Before :
After :
Checklist