-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(settings): Align user management table columns #38424
fix(settings): Align user management table columns #38424
Conversation
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
/backport to stable27 |
@ChristophWurst before and after looks exactly the same? |
No look how the groups header and the contents don't align before ;) |
Ah I looked at the wrong place 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but didnt test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unfortunately that doesn't work like this. please test with more columns
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
is it done? |
unfortunately not. do you have any ideas? |
@AndyScherzinger this won't make it for RC2 apparently. Shall we revert #37870 instead and redo the restructuring cleanly for 28? |
@ChristophWurst @JuliaKirschenheuter yes, let's do that then |
@ChristophWurst please let this branch be alife for a bit |
You can restore the branch at any time. |
Summary
TODO
Checklist