Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(settings): Align user management table columns #38424

Closed

Conversation

ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented May 23, 2023

Summary

Before After
Bildschirmfoto vom 2023-05-23 18-26-12 Bildschirmfoto vom 2023-05-23 18-25-57

TODO

  • Fix the regression

Checklist

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst added this to the Nextcloud 28 milestone May 23, 2023
@ChristophWurst ChristophWurst requested review from JuliaKirschenheuter, a team, susnux, nfebe and szaimen and removed request for a team May 23, 2023 16:27
@ChristophWurst
Copy link
Member Author

/backport to stable27

@szaimen
Copy link
Contributor

szaimen commented May 23, 2023

@ChristophWurst before and after looks exactly the same?

@ChristophWurst
Copy link
Member Author

No look how the groups header and the contents don't align before ;)

@szaimen
Copy link
Contributor

szaimen commented May 23, 2023

No look how the groups header and the contents don't align before ;)

Ah I looked at the wrong place 😅

Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but didnt test

Copy link
Contributor

@JuliaKirschenheuter JuliaKirschenheuter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unfortunately that doesn't work like this. please test with more columns

Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
@JuliaKirschenheuter JuliaKirschenheuter requested a review from Pytal May 24, 2023 15:30
@JuliaKirschenheuter JuliaKirschenheuter marked this pull request as draft May 24, 2023 15:30
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
@JuliaKirschenheuter
Copy link
Contributor

JuliaKirschenheuter commented May 24, 2023

Initial problem seems to that display: grid should't be for #body-settings #app-content.user-list-grid .row. Solution could be to use display: flex for all rows inside a table.

But I still have some problems ;(

  1. Alignment of columns
  2. Styles for editing mode

Screenshot from 2023-05-24 17-41-07
Screenshot from 2023-05-24 17-41-23

@JuliaKirschenheuter
Copy link
Contributor

JuliaKirschenheuter commented May 24, 2023

I've also tried to replace grid column's width, but that haven't worked

Screenshot from 2023-05-24 13-56-31

Now all columns have the same width besides avatar column.

@ChristophWurst ChristophWurst added 2. developing Work in progress and removed 3. to review Waiting for reviews labels May 24, 2023
@ChristophWurst
Copy link
Member Author

is it done?

@JuliaKirschenheuter
Copy link
Contributor

is it done?

unfortunately not. do you have any ideas?

@ChristophWurst
Copy link
Member Author

@AndyScherzinger this won't make it for RC2 apparently. Shall we revert #37870 instead and redo the restructuring cleanly for 28?

@AndyScherzinger
Copy link
Member

Shall we revert #37870 instead and redo the restructuring cleanly for 28?

@ChristophWurst @JuliaKirschenheuter yes, let's do that then

@JuliaKirschenheuter
Copy link
Contributor

#38458

@JuliaKirschenheuter JuliaKirschenheuter removed the 2. developing Work in progress label May 25, 2023
@ChristophWurst ChristophWurst deleted the fix/settings/user-management-table-alignment branch May 25, 2023 10:41
@JuliaKirschenheuter JuliaKirschenheuter restored the fix/settings/user-management-table-alignment branch May 25, 2023 11:31
@JuliaKirschenheuter
Copy link
Contributor

@ChristophWurst please let this branch be alife for a bit

@ChristophWurst
Copy link
Member Author

You can restore the branch at any time.

@skjnldsv skjnldsv deleted the fix/settings/user-management-table-alignment branch March 14, 2024 07:50
@skjnldsv skjnldsv removed this from the Nextcloud 28 milestone Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

5 participants