[stable25] Add commands for basic file actions #38251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![backportbot-nextcloud[bot]](https://avatars.githubusercontent.com/in/21012?s=60&v=4){kind=small}
backportbot-nextcloud
bot
requested review from
come-nc,
icewind1991 and
skjnldsv
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
Psalm found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
Merged
|
backport incomplete |
|
Should apply cleanly once #38253 is merged |
Merged
blizzz
force-pushed
the
backport/37971/stable25
branch
from
27b277e
to
88923b6
Compare
| return 1; | ||
| } | ||
| $source = $node->fopen('r'); | ||
| if (!$source) { |
Check notice
Code scanning / Psalm
DocblockTypeContradiction Note
| } | ||
| if ($node instanceof File) { | ||
| $target = $node->fopen('w'); | ||
| if (!$target) { |
Check notice
Code scanning / Psalm
DocblockTypeContradiction Note
it's merged |
Merged
|
moving to 25.0.10 |
Merged
|
moving to 25.0.11 |
Merged
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
… as argument instead of option Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
backport/37971/stable25
branch
from
88923b6
to
05329e7
Compare
blizzz
added
3. to review
|
moving to 25.0.12 due to lacking reviewers. Thanks for reviving @icewind1991! |
come-nc
approved these changes
Sep 7, 2023
Merged
blizzz
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #37971