Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add messageId to richObject definition of Talk #38102

Conversation

SystemKeeper
Copy link
Contributor

Summary

See nextcloud/spreed#9462

Checklist

@nickvergessen nickvergessen requested a review from vitormattos May 5, 2023 14:15
@AndyScherzinger AndyScherzinger added this to the Nextcloud 27 milestone May 5, 2023
@SystemKeeper SystemKeeper force-pushed the feature/noid/add-messageid-to-talk-richobject-definition branch from 9faf64c to 8bffc3a Compare May 5, 2023 15:49
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
@SystemKeeper SystemKeeper force-pushed the feature/noid/add-messageid-to-talk-richobject-definition branch from 8bffc3a to 484f7a6 Compare May 5, 2023 15:52
@AndyScherzinger AndyScherzinger added enhancement 3. to review Waiting for reviews pending documentation This pull request needs an associated documentation update labels May 5, 2023
@AndyScherzinger
Copy link
Member

I suspect this needs a documentation update, right @nickvergessen ?

@nickvergessen
Copy link
Member

Currently all of this is not documented elsewhere.
I guess we should try to make it exportable as rst and sync it over like the sample.config.php

@nickvergessen nickvergessen merged commit b1c6b94 into master May 8, 2023
@nickvergessen nickvergessen deleted the feature/noid/add-messageid-to-talk-richobject-definition branch May 8, 2023 07:26
@SystemKeeper
Copy link
Contributor Author

So we need to backport to stable27, @nickvergessen ?

@nickvergessen
Copy link
Member

stable27 is only created at RC1

This was referenced May 9, 2023
@DaphneMuller

This comment was marked as resolved.

@nickvergessen nickvergessen removed the pending documentation This pull request needs an associated documentation update label May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants