Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce exif provider errors during file scan #38095

Merged
merged 2 commits into from
May 9, 2023
Merged

Reduce exif provider errors during file scan #38095

merged 2 commits into from
May 9, 2023

Conversation

artonge
Copy link
Contributor

@artonge artonge commented May 5, 2023 •
edited
Loading

Update metadata logic a bit to limits errors during file scan.

  1. Prevent inserting when a metadata already exists to not create error in the middle of a transaction. This causes issue on Postgres.
  2. Reduce EXIF data extraction to a subset of image file formats. This will reduce the amount of exif_read_data(): File not supported error.

@artonge artonge self-assigned this May 5, 2023
@artonge artonge marked this pull request as draft May 5, 2023 11:33
@artonge artonge force-pushed the artonge/fix/file_metadata_scan branch 3 times, most recently from 0f74e64 to 341e70a Compare May 6, 2023 15:34
@artonge artonge requested review from come-nc and a team May 6, 2023 15:35
@artonge artonge marked this pull request as ready for review May 6, 2023 15:35
@artonge artonge added 3. to review Waiting for reviews and removed 2. developing Work in progress labels May 6, 2023
@szaimen szaimen added this to the Nextcloud 27 milestone May 6, 2023
blizzz
blizzz requested changes May 8, 2023
View reviewed changes
Copy link
Member

@blizzz blizzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one question

lib/private/Metadata/FileMetadataMapper.php Show resolved Hide resolved
blizzz
blizzz requested changes May 8, 2023
View reviewed changes
Copy link
Member

@blizzz blizzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one question

@blizzz
Copy link
Member

blizzz commented May 8, 2023

(double review powered by 🪟 :octocat: 🦄 )

This was referenced May 9, 2023
Closed
Merged
@artonge artonge force-pushed the artonge/fix/file_metadata_scan branch from 341e70a to bb1acfb Compare May 9, 2023 08:28
@artonge artonge requested a review from blizzz May 9, 2023 09:08
@artonge artonge requested a review from skjnldsv May 9, 2023 09:39
artonge added 2 commits May 9, 2023 11:43
@artonge
Prevent error on files scan if metadata exists
157be42 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge
Restrict EXIF extracting to a subset of formats
b67e34f 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge artonge force-pushed the artonge/fix/file_metadata_scan branch from bb1acfb to b67e34f Compare May 9, 2023 09:44
@artonge
Copy link
Contributor Author

artonge commented May 9, 2023

/rebase

@artonge artonge enabled auto-merge May 9, 2023 15:24
@skjnldsv skjnldsv disabled auto-merge May 9, 2023 15:28
@skjnldsv skjnldsv merged commit 31302c4 into master May 9, 2023
@skjnldsv skjnldsv deleted the artonge/fix/file_metadata_scan branch May 9, 2023 15:28
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@come-nc come-nc come-nc approved these changes

@blizzz blizzz blizzz approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees

@artonge artonge

Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: files
Projects
None yet
Milestone
Nextcloud 27
Development

Successfully merging this pull request may close these issues.
5 participants
@artonge @blizzz @come-nc @skjnldsv @szaimen