Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix share input id #38012

Merged
merged 1 commit into from
May 3, 2023
Merged

Fix share input id #38012

merged 1 commit into from
May 3, 2023

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented May 2, 2023

Summary

Fix sharing label → input element association

Checklist

@Pytal Pytal added this to the Nextcloud 27 milestone May 2, 2023
@Pytal Pytal self-assigned this May 2, 2023
@Pytal
Copy link
Member Author

Pytal commented May 2, 2023

/compile amend /

@Pytal @nextcloud-command
Fix share input id
8960df2 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@szaimen
Copy link
Contributor

szaimen commented May 2, 2023

What does this fix?

@Pytal
Copy link
Member Author

Pytal commented May 3, 2023

What does this fix?

This correctly associates the label with the VueSelect input element as described in https://www.w3.org/WAI/tutorials/forms/labels/#associating-labels-explicitly

szaimen
szaimen approved these changes May 3, 2023
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me then

@skjnldsv skjnldsv mentioned this pull request May 3, 2023
Merged
@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels May 3, 2023
@Pytal Pytal merged commit 5a7c8b3 into master May 3, 2023
@Pytal Pytal deleted the fix/a11y-share-input branch May 3, 2023 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JuliaKirschenheuter JuliaKirschenheuter JuliaKirschenheuter approved these changes

@artonge artonge artonge approved these changes

@szaimen szaimen szaimen approved these changes

Assignees

@Pytal Pytal

Labels
4. to release Ready to be released and/or waiting for tests to finish accessibility feature: sharing
Projects
None yet
Milestone
Nextcloud 27
Development

Successfully merging this pull request may close these issues.
4 participants
@Pytal @szaimen @JuliaKirschenheuter @artonge