Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix styles for user actions menu #37860

Closed

Conversation

JuliaKirschenheuter
Copy link
Contributor

@JuliaKirschenheuter JuliaKirschenheuter commented Apr 21, 2023

Summary

Fixed styles for actions menu.
Change: I've removed position: sticky for userActions because that causes too many problems. Now user have to scroll to the right side to reach actions button. That is still probably not a best solution but now it is not broken anymore.

Before After
Peek 2023-04-21 11-10 Peek 2023-04-21 11-40
Screenshot from 2023-04-21 11-01-23 Screenshot from 2023-04-21 11-55-21

Checklist

Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
@ShGKme
Copy link
Contributor

ShGKme commented Apr 21, 2023

I'd try to find a solution, that doesn't broke position: sticky.

Current style was a bit incorrect:

  • .userActions had z-index: 10
  • .popovermenu had z-index: 110
  • .userActions is a parent of .popovermenu
  • A child cannot have z-index higher than parent

For position: relative we could just remove z-index: 10. But with position: sticky it works different... position: sticky always creates a new stacking context. It is possible neither to remove z-index from sticky parent, nor to make child with higher z-index...

If I'm not wrong, the only way to keep sticky here is to use another container for NcActions here. For example, #app-content. But I am really not sure, it positions element correct with sticky...

For an experiment, try to set container prop of NcActions here to #app-content.

@JuliaKirschenheuter
Copy link
Contributor Author

For an experiment, try to set container prop of NcActions here to #app-content.

Thanks a lot for your suggestions!
Unfortunately that doesn't helped ;(

@JuliaKirschenheuter
Copy link
Contributor Author

Would like to continue discussion here #37870

@skjnldsv skjnldsv deleted the fix/37857-Users_app_actions_menu_is_broken branch March 14, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BITV]: Bug Users app: actions menu is broken
2 participants