Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a height of the landscape format #37765

Conversation

JuliaKirschenheuter
Copy link
Contributor

  • Resolves: resolves a part of the customer issue 44701 regarding landscape format.
    Remove height rule for video viewer.

Summary

Before After
Screenshot from 2023-04-17 11-31-24 image

Checklist

Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
Comment on lines -43 to -45
#imgframe video {
max-height: calc(100vh - var(--header-height) - #{$footer-height} - #{$download-button-section-height} - #{$footer-padding-height});
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fear removing this will lead to an overlapping footer again depending on the video size. (please trest with a portait video). Also see #33803 and #34028

@JuliaKirschenheuter
Copy link
Contributor Author

not relevant anymore

@skjnldsv skjnldsv deleted the fix/44701-fix_landscape_format_for_video_viewer branch March 14, 2024 07:50
@skjnldsv skjnldsv removed this from the Nextcloud 28 milestone Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants