Make it possible to strong type Entity properties #37209
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
come-nc
force-pushed
the
fix/type-entity-properties
branch
from
7127218 to
739f2ca
Compare
come-nc
added
3. to review
come-nc
requested review from
a team,
ArtificialOwl,
icewind1991,
blizzz and
artonge
and removed request for
a team
This was referenced May 3, 2023
Merged
Closed
Merged
Pytal
reviewed
May 9, 2023
Pytal
approved these changes
May 9, 2023
artonge
approved these changes
May 11, 2023
| @@ -29,16 +29,16 @@ | |||
| use function substr; | |||
|
|
|||
| /** | |||
| * @method int getId() | |||
| * @method ?int getId() | |||
Check failure
Code scanning / Psalm
ImplementedReturnTypeMismatch
There was a problem hiding this comment.
I do not understand this error, OC\Authentication\Token\PublicKeyToken::getId has a return type of int, not ?int.
|
/rebase |
come-nc
force-pushed
the
fix/type-entity-properties
branch
from
4fce81e to
34d2622
Compare
szaimen
added
2. developing
PropertyNotSetInConstructor still have to be suppressed because properties are actually set in fromRow/fromParams methods, and the init path is too convoluted anyway. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
come-nc
force-pushed
the
fix/type-entity-properties
branch
from
34d2622 to
f7a61ac
Compare
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Merged
Merged
Merged
|
Giving up on this one 😢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PropertyNotSetInConstructor still have to be suppressed because properties are
actually set in fromRow/fromParams methods, and the init path is too
convoluted anyway.
Summary
I tried several solutions to improve typing for QBMapper/Entity, I could not find a clean way to type properties without suppressing PropertyNotSetInConstructor manually and adding the @method annotations by hand as well.
But at least we can now type those properties and have psalm-compliant entities.
Also id property is actually nullable and null by default for autoincrement, made that clear in the code.
Checklist